fix: detect plugin getSetting method when present (#14077)

* fix: detect plugin getSetting method when present * Add getSettings to vm test expects --------- Co-authored-by: Harry Waye <[email protected]>
PostHog · Feb 4, 2023 · ba9085c · ba9085c
1 parent a7724d4
commit ba9085c
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/plugin-server/src/worker/vm/vm.ts b/plugin-server/src/worker/vm/vm.ts
@@ -184,6 +184,7 @@ export function createPluginConfigVM(
                 onEvent: __asyncFunctionGuard(__bindMeta('onEvent'), 'onEvent'),
                 onSnapshot: __asyncFunctionGuard(__bindMeta('onSnapshot'), 'onSnapshot'),
                 processEvent: __asyncFunctionGuard(__bindMeta('processEvent'), 'processEvent'),
+                getSettings: __bindMeta('getSettings'),
             };
 
             const __tasks = {

diff --git a/plugin-server/tests/worker/capabilities.test.ts b/plugin-server/tests/worker/capabilities.test.ts
@@ -52,7 +52,7 @@ describe('capabilities', () => {
                 export function randomFunction (event, meta) { return event}
                 export function onEvent (event, meta) { return event }
                 export function onSnapshot (event, meta) { return event }
-
+                export function getSettings (meta) { return { handlesLargeBatches: true } }
                 export function runEveryHour(meta) {console.log('1')}
 
                 export const jobs = {
@@ -62,7 +62,7 @@ describe('capabilities', () => {
             expect(capabilities).toEqual({
                 jobs: ['x'],
                 scheduled_tasks: ['runEveryHour'],
-                methods: ['onEvent', 'onSnapshot', 'processEvent'],
+                methods: ['onEvent', 'onSnapshot', 'processEvent', 'getSettings'],
             })
         })
     })

diff --git a/plugin-server/tests/worker/plugins.test.ts b/plugin-server/tests/worker/plugins.test.ts
@@ -82,6 +82,7 @@ describe('plugins', () => {
         const vm = await pluginConfig.vm!.resolveInternalVm
         expect(Object.keys(vm!.methods).sort()).toEqual([
             'exportEvents',
+            'getSettings',
             'onEvent',
             'onSnapshot',
             'processEvent',

diff --git a/plugin-server/tests/worker/vm.test.ts b/plugin-server/tests/worker/vm.test.ts
@@ -60,6 +60,7 @@ describe('vm tests', () => {
         expect(Object.keys(vm).sort()).toEqual(['methods', 'tasks', 'vm', 'vmResponseVariable'])
         expect(Object.keys(vm.methods).sort()).toEqual([
             'exportEvents',
+            'getSettings',
             'onEvent',
             'onSnapshot',
             'processEvent',