fix(cdp): allow falsy default values (#25672)

PostHog · Oct 18, 2024 · b9313b8 · b9313b8
1 parent e3544ca
commit b9313b8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/frontend/src/scenes/pipeline/hogfunctions/HogFunctionInputs.tsx b/frontend/src/scenes/pipeline/hogfunctions/HogFunctionInputs.tsx
@@ -175,7 +175,6 @@ export function HogFunctionInputRenderer({ value, onChange, schema, disabled }:
             )
         case 'dictionary':
             return <DictionaryField value={value} onChange={onChange} />
-
         case 'boolean':
             return <LemonSwitch checked={value} onChange={(checked) => onChange?.(checked)} disabled={disabled} />
         case 'integration':

diff --git a/frontend/src/scenes/pipeline/hogfunctions/hogFunctionConfigurationLogic.test.ts b/frontend/src/scenes/pipeline/hogfunctions/hogFunctionConfigurationLogic.test.ts
@@ -183,6 +183,9 @@ describe('hogFunctionConfigurationLogic', () => {
                             person: '{person}',
                         },
                     },
+                    debug: {
+                        value: false,
+                    },
                 },
                 enabled: true,
             })

diff --git a/frontend/src/scenes/pipeline/hogfunctions/hogFunctionConfigurationLogic.tsx b/frontend/src/scenes/pipeline/hogfunctions/hogFunctionConfigurationLogic.tsx
@@ -112,7 +112,7 @@ const templateToConfiguration = (
     template.inputs_schema?.forEach((schema) => {
         if (typeof subTemplate?.inputs?.[schema.key] !== 'undefined') {
             inputs[schema.key] = { value: subTemplate.inputs[schema.key] }
-        } else if (schema.default) {
+        } else if (schema.default !== undefined) {
             inputs[schema.key] = { value: schema.default }
         }
     })