fix: avoid setting filters if a filters attachment already exists (#2…

…3877)
PostHog · Jul 23, 2024 · b5ac066 · b5ac066
1 parent 591b5af
commit b5ac066
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/frontend/src/scenes/pipeline/pipelinePluginConfigurationLogic.tsx b/frontend/src/scenes/pipeline/pipelinePluginConfigurationLogic.tsx
@@ -148,7 +148,8 @@ export const pipelinePluginConfigurationLogic = kea<pipelinePluginConfigurationL
                         lemonToast.error('Data pipelines add-on is required for enabling new destinations.')
                         return values.pluginConfig
                     }
-                    const { enabled, order, name, description, filters, ...config } = formdata
+                    const { enabled, order, name, description, ...config } = formdata
+                    const { filters } = formdata // This is to make sure the config object includes the filters field
 
                     const formData = getPluginConfigFormData(
                         values.plugin.config_schema,
@@ -160,7 +161,7 @@ export const pipelinePluginConfigurationLogic = kea<pipelinePluginConfigurationL
                     formData.append('description', description)
 
                     const sanitizedFilters = sanitizeFilters(filters)
-                    if (filters) {
+                    if (filters && !formData.has('add_attachment[filters]')) {
                         formData.append('filters', sanitizedFilters ? JSON.stringify(sanitizedFilters) : '')
                     }