Skip to content

Commit

Permalink
fix(surveys): rename widget to feedback button (#19318)
Browse files Browse the repository at this point in the history
rename widget to feedback button
  • Loading branch information
liyiy authored Dec 14, 2023
1 parent e3a1a7b commit ae14c3d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
10 changes: 5 additions & 5 deletions frontend/src/scenes/surveys/SurveyAppearance.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ export function Customization({ appearance, surveyQuestionItem, onAppearanceChan
export function WidgetCustomization({ appearance, onAppearanceChange }: WidgetCustomizationProps): JSX.Element {
return (
<>
<div className="mt-2">Widget type</div>
<div className="mt-2">Feedback button type</div>
<LemonSelect
value={appearance.widgetType}
onChange={(widgetType) => onAppearanceChange({ ...appearance, widgetType })}
Expand All @@ -245,21 +245,21 @@ export function WidgetCustomization({ appearance, onAppearanceChange }: WidgetCu
/>
{appearance.widgetType === 'selector' ? (
<>
<div className="mt-2">Widget selector</div>
<div className="mt-2">Class or ID selector</div>
<LemonInput
value={appearance.widgetSelector}
onChange={(widgetSelector) => onAppearanceChange({ ...appearance, widgetSelector })}
placeholder="ex: .feedback-button"
placeholder="ex: .feedback-button, #feedback-button"
/>
</>
) : (
<>
<div className="mt-2">Widget label</div>
<div className="mt-2">Label</div>
<LemonInput
value={appearance.widgetLabel}
onChange={(widgetLabel) => onAppearanceChange({ ...appearance, widgetLabel })}
/>
<div className="mt-2">Widget color</div>
<div className="mt-2">Background color</div>
<LemonInput
value={appearance.widgetColor}
onChange={(widgetColor) => onAppearanceChange({ ...appearance, widgetColor })}
Expand Down
8 changes: 5 additions & 3 deletions frontend/src/scenes/surveys/SurveyEdit.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,8 @@ export default function SurveyEdit(): JSX.Element {
<PresentationTypeCard
active={value === SurveyType.Widget}
onClick={() => onChange(SurveyType.Widget)}
title="Widget (beta)"
description="Set up a survey based on your own custom button or our prebuilt tab widget"
title="Feedback button (beta)"
description="Set up a survey based on your own custom button or our prebuilt feedback tab"
value={SurveyType.Widget}
>
<LemonTag type="warning" className="uppercase ml-2">
Expand Down Expand Up @@ -354,7 +354,9 @@ export default function SurveyEdit(): JSX.Element {
<>
{survey.type === SurveyType.Widget && (
<>
<div className="font-bold">Widget customization</div>
<div className="font-bold">
Feedback button customization
</div>
<WidgetCustomization
appearance={value || defaultSurveyAppearance}
onAppearanceChange={(appearance) => {
Expand Down

0 comments on commit ae14c3d

Please sign in to comment.