final fixes

PostHog · Jun 21, 2024 · ab42e2f · ab42e2f
1 parent 25c9aa0
commit ab42e2f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/hogql_parser/parser.cpp b/hogql_parser/parser.cpp
@@ -581,9 +581,17 @@ class HogQLParseTreeConverter : public HogQLParserBaseVisitor {
   }
 
   VISIT(FuncStmt) {
+    PyObject* params;
     string name = visitAsString(ctx->identifier());
-    vector<string> paramList = any_cast<vector<string>>(visit(ctx->identifierList()));
-    PyObject* params = X_PyList_FromStrings(paramList);
+    auto identifier_list_ctx = ctx->identifierList();
+    if (identifier_list_ctx) {
+      vector<string> paramList = any_cast<vector<string>>(visit(ctx->identifierList()));
+      params = X_PyList_FromStrings(paramList);
+    } else {
+      vector<string> paramList;
+      params = PyList_New(0);
+    }
+
     if (!params) {
         throw PyInternalError();
     }

diff --git a/hogql_parser/setup.py b/hogql_parser/setup.py
@@ -32,7 +32,7 @@
 
 setup(
     name="hogql_parser",
-    version="1.0.20",
+    version="1.0.21",
     url="https://github.com/PostHog/posthog/tree/master/hogql_parser",
     author="PostHog Inc.",
     author_email="[email protected]",