fix(backfill-batch-exports): Do not run partial ranges (#18114)

PostHog · Oct 19, 2023 · aaf76ac · aaf76ac
1 parent 1dc09c2
commit aaf76ac
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/posthog/temporal/tests/batch_exports/test_backfill_batch_export.py b/posthog/temporal/tests/batch_exports/test_backfill_batch_export.py
@@ -128,6 +128,21 @@ async def temporal_worker(temporal_client):
                 )
             ],
         ),
+        (
+            dt.datetime(2023, 1, 1, 10, 0, 0, tzinfo=dt.timezone.utc),
+            dt.datetime(2023, 1, 1, 12, 20, 0, tzinfo=dt.timezone.utc),
+            dt.timedelta(hours=1),
+            [
+                (
+                    dt.datetime(2023, 1, 1, 10, 0, 0, tzinfo=dt.timezone.utc),
+                    dt.datetime(2023, 1, 1, 11, 0, 0, tzinfo=dt.timezone.utc),
+                ),
+                (
+                    dt.datetime(2023, 1, 1, 11, 0, 0, tzinfo=dt.timezone.utc),
+                    dt.datetime(2023, 1, 1, 12, 0, 0, tzinfo=dt.timezone.utc),
+                ),
+            ],
+        ),
         (
             dt.datetime(2023, 1, 1, 0, 0, 0, tzinfo=dt.timezone.utc),
             dt.datetime(2023, 1, 2, 0, 0, 0, tzinfo=dt.timezone.utc),

diff --git a/posthog/temporal/workflows/backfill_batch_export.py b/posthog/temporal/workflows/backfill_batch_export.py
@@ -244,7 +244,9 @@ def backfill_range(
         current_end = current + step
 
         if current_end > end_at:
-            current_end = end_at
+            # Do not yield a range that is less than step.
+            # Same as built-in range.
+            break
 
         yield current, current_end