feat(pipeline): add destination history (#19714)

* implement activity log * Update UI snapshots for `chromium` (1) * fixes * Update UI snapshots for `chromium` (1) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Michael Matloka <[email protected]>
PostHog · Jan 16, 2024 · aa0b801 · aa0b801
1 parent 88cd774
commit aa0b801
Show file tree

Hide file tree

Showing 17 changed files with 14 additions and 1 deletion.
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-app-configuration--dark.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-app-configuration--dark.png
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-app-configuration--light.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-app-configuration--light.png
diff --git a/...end/__snapshots__/scenes-app-pipeline--pipeline-app-configuration-404--dark.png b/...end/__snapshots__/scenes-app-pipeline--pipeline-app-configuration-404--dark.png
diff --git a/...nd/__snapshots__/scenes-app-pipeline--pipeline-app-configuration-404--light.png b/...nd/__snapshots__/scenes-app-pipeline--pipeline-app-configuration-404--light.png
diff --git a/...d/__snapshots__/scenes-app-pipeline--pipeline-app-configuration-empty--dark.png b/...d/__snapshots__/scenes-app-pipeline--pipeline-app-configuration-empty--dark.png
diff --git a/.../__snapshots__/scenes-app-pipeline--pipeline-app-configuration-empty--light.png b/.../__snapshots__/scenes-app-pipeline--pipeline-app-configuration-empty--light.png
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-app-logs--dark.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-app-logs--dark.png
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-app-logs--light.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-app-logs--light.png
diff --git a/...end/__snapshots__/scenes-app-pipeline--pipeline-app-logs-batch-export--dark.png b/...end/__snapshots__/scenes-app-pipeline--pipeline-app-logs-batch-export--dark.png
diff --git a/...nd/__snapshots__/scenes-app-pipeline--pipeline-app-logs-batch-export--light.png b/...nd/__snapshots__/scenes-app-pipeline--pipeline-app-logs-batch-export--light.png
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-app-metrics--dark.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-app-metrics--dark.png
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-app-metrics--light.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-app-metrics--light.png
diff --git a/...d/__snapshots__/scenes-app-pipeline--pipeline-app-metrics-error-modal--dark.png b/...d/__snapshots__/scenes-app-pipeline--pipeline-app-metrics-error-modal--dark.png
diff --git a/.../__snapshots__/scenes-app-pipeline--pipeline-app-metrics-error-modal--light.png b/.../__snapshots__/scenes-app-pipeline--pipeline-app-metrics-error-modal--light.png
diff --git a/frontend/src/scenes/pipeline/PipelineApp.tsx b/frontend/src/scenes/pipeline/PipelineApp.tsx
@@ -1,4 +1,5 @@
 import { useValues } from 'kea'
+import { ActivityLog } from 'lib/components/ActivityLog/ActivityLog'
 import { NotFound } from 'lib/components/NotFound'
 import { PageHeader } from 'lib/components/PageHeader'
 import { FEATURE_FLAGS } from 'lib/constants'
@@ -9,7 +10,7 @@ import { PipelineAppLogs } from 'scenes/pipeline/PipelineAppLogs'
 import { SceneExport } from 'scenes/sceneTypes'
 import { urls } from 'scenes/urls'
 
-import { PipelineAppKind, PipelineAppTab, PipelineTab } from '~/types'
+import { ActivityScope, PipelineAppKind, PipelineAppTab, PipelineTab } from '~/types'
 
 import { PipelineAppConfiguration } from './PipelineAppConfiguration'
 import { pipelineAppLogic, PipelineAppLogicProps } from './pipelineAppLogic'
@@ -65,6 +66,7 @@ export function PipelineApp(params: { kindTab?: string; id?: string } = {}): JSX
         [PipelineAppTab.Configuration]: <PipelineAppConfiguration />,
         [PipelineAppTab.Metrics]: <PipelineAppMetrics pluginConfigId={id as number} />,
         [PipelineAppTab.Logs]: <PipelineAppLogs id={id} kind={kind} />,
+        [PipelineAppTab.History]: <ActivityLog id={id} scope={ActivityScope.PLUGIN} />,
     }
 
     return (

diff --git a/frontend/src/scenes/pipeline/pipelineAppLogic.tsx b/frontend/src/scenes/pipeline/pipelineAppLogic.tsx
@@ -68,6 +68,16 @@ export const pipelineAppLogic = kea<pipelineAppLogicType>([
                 return pluginConfigsLoading || pluginsLoading
             },
         ],
+        tabs: [
+            (s) => [s.appBackend],
+            (appBackend) => {
+                if (appBackend === PipelineAppBackend.BatchExport) {
+                    return Object.values(PipelineAppTab).filter((t) => t !== PipelineAppTab.History)
+                }
+
+                return Object.values(PipelineAppTab)
+            },
+        ],
         maybePluginConfig: [
             (s, p) => [s.pluginConfigs, s.appBackend, p.id],
             (pluginConfigs, appBackend, maybePluginConfigId): PluginConfigTypeNew | null => {

diff --git a/frontend/src/types.ts b/frontend/src/types.ts
@@ -542,6 +542,7 @@ export enum PipelineAppTab {
     Configuration = 'configuration',
     Logs = 'logs',
     Metrics = 'metrics',
+    History = 'history',
 }
 
 export enum ProgressStatus {