fix: allow flagging of settings as well as sections of settings (#18530)

PostHog · Nov 9, 2023 · a9c22d3 · a9c22d3
1 parent 982f7a3
commit a9c22d3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/frontend/src/scenes/settings/SettingsMap.tsx b/frontend/src/scenes/settings/SettingsMap.tsx
@@ -156,6 +156,7 @@ export const SettingsMap: SettingSection[] = [
                 id: 'replay-ingestion',
                 title: 'Ingestion controls',
                 component: <ReplayCostControl />,
+                flag: 'SESSION_RECORDING_SAMPLING',
             },
         ],
     },

diff --git a/frontend/src/scenes/settings/settingsLogic.ts b/frontend/src/scenes/settings/settingsLogic.ts
@@ -76,8 +76,8 @@ export const settingsLogic = kea<settingsLogicType>([
             },
         ],
         settings: [
-            (s) => [s.selectedLevel, s.selectedSectionId, s.sections],
-            (selectedLevel, selectedSectionId, sections): Setting[] => {
+            (s) => [s.selectedLevel, s.selectedSectionId, s.sections, s.featureFlags],
+            (selectedLevel, selectedSectionId, sections, featureFlags): Setting[] => {
                 let settings: Setting[] = []
 
                 if (!selectedSectionId) {
@@ -88,7 +88,7 @@ export const settingsLogic = kea<settingsLogicType>([
                     settings = sections.find((x) => x.id === selectedSectionId)?.settings || []
                 }
 
-                return settings
+                return settings.filter((x) => (x.flag ? featureFlags[FEATURE_FLAGS[x.flag]] : true))
             },
         ],
     }),

diff --git a/frontend/src/scenes/settings/types.ts b/frontend/src/scenes/settings/types.ts
@@ -67,6 +67,7 @@ export type Setting = {
     title: string
     description?: JSX.Element | string
     component: JSX.Element
+    flag?: keyof typeof FEATURE_FLAGS
 }
 
 export type SettingSection = {