fix types

PostHog · Mar 29, 2024 · a3acece · a3acece
1 parent ef11a54
commit a3acece
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/frontend/src/scenes/experiments/ExperimentView/SecondaryMetricsTable.tsx b/frontend/src/scenes/experiments/ExperimentView/SecondaryMetricsTable.tsx
@@ -12,7 +12,7 @@ import { capitalizeFirstLetter } from 'lib/utils'
 import { filtersToQueryNode } from '~/queries/nodes/InsightQuery/utils/filtersToQueryNode'
 import { Query } from '~/queries/Query/Query'
 import { NodeKind } from '~/queries/schema'
-import { ExperimentResults, InsightShortId, InsightType } from '~/types'
+import { BaseExperimentResults, InsightShortId, InsightType } from '~/types'
 
 import { SECONDARY_METRIC_INSIGHT_ID } from '../constants'
 import { experimentLogic, TabularSecondaryMetricResults } from '../experimentLogic'
@@ -219,7 +219,7 @@ export function SecondaryMetricsTable({
 
         const targetResults = secondaryMetricResults?.[idx]
         const targetResultFilters = targetResults?.filters
-        const winningVariant = getHighestProbabilityVariant(targetResults as ExperimentResults['result'])
+        const winningVariant = getHighestProbabilityVariant(targetResults as BaseExperimentResults)
 
         if (metric.filters.insight === InsightType.TRENDS) {
             columns.push({

diff --git a/frontend/src/scenes/experiments/experimentLogic.tsx b/frontend/src/scenes/experiments/experimentLogic.tsx
@@ -26,6 +26,7 @@ import { queryNodeToFilter } from '~/queries/nodes/InsightQuery/utils/queryNodeT
 import { FunnelsQuery, InsightVizNode, TrendsQuery } from '~/queries/schema'
 import {
     ActionFilter as ActionFilterType,
+    BaseExperimentResults,
     Breadcrumb,
     CountPerActorMathType,
     Experiment,
@@ -964,7 +965,7 @@ export const experimentLogic = kea<experimentLogicType>([
         ],
         getHighestProbabilityVariant: [
             () => [],
-            () => (results: ExperimentResults['result'] | null) => {
+            () => (results: BaseExperimentResults | null) => {
                 if (results) {
                     const maxValue = Math.max(...Object.values(results.probability))
                     return Object.keys(results.probability).find(

diff --git a/frontend/src/types.ts b/frontend/src/types.ts
@@ -2884,7 +2884,7 @@ export interface TrendExperimentVariant {
     absolute_exposure: number
 }
 
-interface BaseExperimentResults {
+export interface BaseExperimentResults {
     probability: Record<string, number>
     fakeInsightId: string
     significant: boolean