fix: error title parsing

PostHog · Mar 25, 2024 · a1aa41c · a1aa41c
1 parent 67a2759
commit a1aa41c
Showing 1 changed file with 5 additions and 8 deletions.
diff --git a/frontend/src/scenes/session-recordings/errors/SessionRecordingErrors.tsx b/frontend/src/scenes/session-recordings/errors/SessionRecordingErrors.tsx
@@ -1,5 +1,5 @@
 import { IconFeatures } from '@posthog/icons'
-import { LemonButton, LemonTable, LemonTabs, Spinner } from '@posthog/lemon-ui'
+import { LemonButton, LemonTable, LemonTabs } from '@posthog/lemon-ui'
 import { useActions, useValues } from 'kea'
 import { JSONViewer } from 'lib/components/JSONViewer'
 import { Sparkline } from 'lib/lemon-ui/Sparkline'
@@ -17,11 +17,7 @@ export function SessionRecordingErrors(): JSX.Element {
     const { errors, errorsLoading } = useValues(sessionRecordingErrorsLogic)
     const { loadErrorClusters, createPlaylist } = useActions(sessionRecordingErrorsLogic)
 
-    if (errorsLoading) {
-        return <Spinner />
-    }
-
-    if (!errors) {
+    if (!errors && !errorsLoading) {
         return (
             <LemonButton size="large" type="primary" icon={<IconFeatures />} onClick={() => loadErrorClusters()}>
                 Automagically find errors
@@ -110,7 +106,8 @@ export function SessionRecordingErrors(): JSX.Element {
                         },
                     },
                 ]}
-                dataSource={errors}
+                loading={errorsLoading}
+                dataSource={errors || []}
                 expandable={{
                     expandedRowRender: (cluster) => <ExpandedError error={cluster.sample} />,
                 }}
@@ -165,5 +162,5 @@ function parseTitle(error: string): string {
         input = error
     }
 
-    return input.split('\n')[0].trim().substring(0, MAX_TITLE_LENGTH)
+    return input?.split('\n')[0].trim().substring(0, MAX_TITLE_LENGTH) || error
 }