feat: Add pipeline ui fields to plugin config

PostHog · Nov 3, 2023 · a0a53f7 · a0a53f7
1 parent 4e0ad8b
commit a0a53f7
Show file tree

Hide file tree

Showing 5 changed files with 45 additions and 1 deletion.
diff --git a/latest_migrations.manifest b/latest_migrations.manifest
@@ -5,7 +5,7 @@ contenttypes: 0002_remove_content_type_name
 ee: 0015_add_verified_properties
 otp_static: 0002_throttling
 otp_totp: 0002_auto_20190420_0723
-posthog: 0359_team_external_data_workspace_id
+posthog: 0360_auto_20231103_1229
 sessions: 0001_initial
 social_django: 0010_uid_db_index
 two_factor: 0007_auto_20201201_1019
diff --git a/posthog/api/plugin.py b/posthog/api/plugin.py
@@ -503,6 +503,10 @@ class Meta:
             "plugin_info",
             "delivery_rate_24h",
             "created_at",
+            "updated_at",
+            "name",
+            "description",
+            "deleted",
         ]
         read_only_fields = [
             "id",

diff --git a/posthog/api/test/test_plugin.py b/posthog/api/test/test_plugin.py
@@ -935,6 +935,8 @@ def test_create_plugin_config(self, mock_get, mock_reload):
                 "enabled": True,
                 "order": 0,
                 "config": json.dumps({"bar": "moop"}),
+                "name": "name in ui",
+                "description": "description in ui",
             },
             format="multipart",
         )
@@ -955,6 +957,9 @@ def test_create_plugin_config(self, mock_get, mock_reload):
                 "plugin_info": None,
                 "delivery_rate_24h": None,
                 "created_at": mock.ANY,
+                "name": "name in ui",
+                "description": "description in ui",
+                "deleted": False,
             },
         )
         plugin_config = PluginConfig.objects.first()
@@ -993,6 +998,9 @@ def test_create_plugin_config(self, mock_get, mock_reload):
                 "plugin_info": None,
                 "delivery_rate_24h": None,
                 "created_at": mock.ANY,
+                "name": "name in ui",
+                "description": "description in ui",
+                "deleted": False,
             },
         )
         self.client.delete(f"/api/plugin_config/{plugin_config_id}")

diff --git a/posthog/migrations/0360_add_plugin_config_ui_fields.py b/posthog/migrations/0360_add_plugin_config_ui_fields.py
@@ -0,0 +1,27 @@
+# Generated by Django 3.2.19 on 2023-11-03 12:29
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("posthog", "0359_team_external_data_workspace_id"),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name="pluginconfig",
+            name="deleted",
+            field=models.BooleanField(blank=True, default=False, null=True),
+        ),
+        migrations.AddField(
+            model_name="pluginconfig",
+            name="description",
+            field=models.CharField(blank=True, max_length=400, null=True),
+        ),
+        migrations.AddField(
+            model_name="pluginconfig",
+            name="name",
+            field=models.CharField(blank=True, max_length=400, null=True),
+        ),
+    ]
diff --git a/posthog/models/plugin.py b/posthog/models/plugin.py
@@ -237,6 +237,11 @@ class Meta:
 
     created_at: models.DateTimeField = models.DateTimeField(auto_now_add=True)
     updated_at: models.DateTimeField = models.DateTimeField(auto_now=True)
+    # Used in the frontend
+    name: models.CharField = models.CharField(max_length=400, null=True, blank=True)
+    description: models.CharField = models.CharField(max_length=400, null=True, blank=True)
+    # Used in the frontend to hide pluginConfgis that user deleted
+    deleted: models.BooleanField = models.BooleanField(default=False, null=True, blank=True)
 
 
 class PluginAttachment(models.Model):