fix: waterfall empty statae (#22508)

PostHog · May 25, 2024 · a095c1d · a095c1d
1 parent 82be493
commit a095c1d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/frontend/src/scenes/session-recordings/apm/NetworkView.tsx b/frontend/src/scenes/session-recordings/apm/NetworkView.tsx
@@ -137,7 +137,7 @@ function WaterfallMeta(): JSX.Element | null {
 
 export function NetworkView({ sessionRecordingId }: { sessionRecordingId: string }): JSX.Element {
     const logic = networkViewLogic({ sessionRecordingId })
-    const { isLoading, currentPage } = useValues(logic)
+    const { isLoading, currentPage, hasPageViews } = useValues(logic)
 
     if (isLoading) {
         return (
@@ -157,6 +157,11 @@ export function NetworkView({ sessionRecordingId }: { sessionRecordingId: string
                         className="NetworkView__table"
                         size="small"
                         dataSource={currentPage}
+                        emptyState={
+                            hasPageViews
+                                ? 'error displaying network data'
+                                : 'network data does not include any "navigation" events'
+                        }
                         columns={[
                             {
                                 title: 'URL',

diff --git a/frontend/src/scenes/session-recordings/apm/networkViewLogic.ts b/frontend/src/scenes/session-recordings/apm/networkViewLogic.ts
@@ -150,5 +150,6 @@ export const networkViewLogic = kea<networkViewLogicType>([
                 }
             },
         ],
+        hasPageViews: [(s) => [s.pageCount], (pageCount) => pageCount > 0],
     }),
 ])
-Original file line number
+Diff line change
@@ Expand Up / @@ -150,5 +150,6 @@ export const networkViewLogic = kea<networkViewLogicType>([ @@
                     }
                 },
             ],
+            hasPageViews: [(s) => [s.pageCount], (pageCount) => pageCount > 0],
         }),
     ])