Skip to content

Commit

Permalink
remove propsQuery
Browse files Browse the repository at this point in the history
  • Loading branch information
thmsobrmlr committed Nov 7, 2023
1 parent 291f93c commit a073926
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions frontend/src/scenes/insights/insightDataLogic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,21 +84,14 @@ export const insightDataLogic = kea<insightDataLogicType>([

selectors({
query: [
(s) => [s.propsQuery, s.filters, s.insight, s.internalQuery, s.filterTestAccountsDefault],
(propsQuery, filters, insight, internalQuery, filterTestAccountsDefault) =>
propsQuery ||
(s) => [s.filters, s.insight, s.internalQuery, s.filterTestAccountsDefault],
(filters, insight, internalQuery, filterTestAccountsDefault) =>
internalQuery ||
insight.query ||
(filters && filters.insight ? queryFromFilters(filters) : undefined) ||
queryFromKind(NodeKind.TrendsQuery, filterTestAccountsDefault),
],

propsQuery: [
() => [(_, props) => props],
// overwrite query from props for standalone InsightVizNode queries
(props: InsightLogicProps) => (props.dashboardItemId?.startsWith('new-AdHoc.') ? props.query : null),
],

isQueryBasedInsight: [
(s) => [s.query],
(query) => {
Expand Down

0 comments on commit a073926

Please sign in to comment.