feat: add a notice that cohorts are preferred (#26551)

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
PostHog · Nov 30, 2024 · 9e145db · 9e145db
1 parent b43825f
commit 9e145db
Show file tree

Hide file tree

Showing 17 changed files with 8 additions and 3 deletions.
diff --git a/frontend/__snapshots__/scenes-other-settings--settings-project--dark.png b/frontend/__snapshots__/scenes-other-settings--settings-project--dark.png
diff --git a/frontend/__snapshots__/scenes-other-settings--settings-project--light.png b/frontend/__snapshots__/scenes-other-settings--settings-project--light.png
diff --git a/...pshots__/scenes-other-settings--settings-project-with-replay-features--dark.png b/...pshots__/scenes-other-settings--settings-project-with-replay-features--dark.png
diff --git a/...shots__/scenes-other-settings--settings-project-with-replay-features--light.png b/...shots__/scenes-other-settings--settings-project-with-replay-features--light.png
diff --git a/...apshots__/scenes-other-settings--settings-session-timeout-all-options--dark.png b/...apshots__/scenes-other-settings--settings-session-timeout-all-options--dark.png
diff --git a/...pshots__/scenes-other-settings--settings-session-timeout-all-options--light.png b/...pshots__/scenes-other-settings--settings-session-timeout-all-options--light.png
diff --git a/...shots__/scenes-other-settings--settings-session-timeout-password-only--dark.png b/...shots__/scenes-other-settings--settings-session-timeout-password-only--dark.png
diff --git a/...hots__/scenes-other-settings--settings-session-timeout-password-only--light.png b/...hots__/scenes-other-settings--settings-session-timeout-password-only--light.png
diff --git a/..._/scenes-other-settings--settings-session-timeout-sso-enforced-github--dark.png b/..._/scenes-other-settings--settings-session-timeout-sso-enforced-github--dark.png
diff --git a/.../scenes-other-settings--settings-session-timeout-sso-enforced-github--light.png b/.../scenes-other-settings--settings-session-timeout-sso-enforced-github--light.png
diff --git a/..._/scenes-other-settings--settings-session-timeout-sso-enforced-google--dark.png b/..._/scenes-other-settings--settings-session-timeout-sso-enforced-google--dark.png
diff --git a/.../scenes-other-settings--settings-session-timeout-sso-enforced-google--light.png b/.../scenes-other-settings--settings-session-timeout-sso-enforced-google--light.png
diff --git a/...s__/scenes-other-settings--settings-session-timeout-sso-enforced-saml--dark.png b/...s__/scenes-other-settings--settings-session-timeout-sso-enforced-saml--dark.png
diff --git a/...__/scenes-other-settings--settings-session-timeout-sso-enforced-saml--light.png b/...__/scenes-other-settings--settings-session-timeout-sso-enforced-saml--light.png
diff --git a/..._snapshots__/scenes-other-settings--settings-session-timeout-sso-only--dark.png b/..._snapshots__/scenes-other-settings--settings-session-timeout-sso-only--dark.png
diff --git a/...snapshots__/scenes-other-settings--settings-session-timeout-sso-only--light.png b/...snapshots__/scenes-other-settings--settings-session-timeout-sso-only--light.png
diff --git a/frontend/src/scenes/settings/environment/TestAccountFiltersConfig.tsx b/frontend/src/scenes/settings/environment/TestAccountFiltersConfig.tsx
@@ -69,7 +69,12 @@ function TestAccountFiltersConfig(): JSX.Element {
 
     return (
         <div className="mb-4 flex flex-col gap-2">
-            <div className="mb-4">
+            <div className="mb-4 flex flex-col gap-2">
+                <LemonBanner type="info">
+                    When filtering out internal users by person properties, like email, we recommend creating a Cohort
+                    with those properties, and then adding that cohort with a "not in" operator in your ‘Filter out
+                    internal and test users’ settings.
+                </LemonBanner>
                 {!!testAccountFilterWarningLabels && testAccountFilterWarningLabels.length > 0 && (
                     <LemonBanner type="warning" className="m-2">
                         <p>
@@ -141,8 +146,8 @@ export function ProjectAccountFiltersSetting(): JSX.Element {
                 <strong>Example filters</strong>
                 <ul className="list-disc pl-4 mb-2">
                     <li>
-                        Add "<strong>Email</strong> does not contain <strong>yourcompany.com</strong>" to exclude your
-                        team.
+                        Add a cohort where "<strong>Email</strong> does not contain <strong>yourcompany.com</strong>" to
+                        exclude your team.
                     </li>
                     <li>
                         Add "<strong>Host</strong> does not contain <strong>localhost</strong>" to exclude local