fix(hogql): Fix query for array of values (#18742)

Fixes #18651
PostHog · Nov 20, 2023 · 9a5c644 · 9a5c644
1 parent c04b5df
commit 9a5c644
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 21 deletions.
diff --git a/posthog/hogql/property.py b/posthog/hogql/property.py
@@ -126,26 +126,35 @@ def property_to_expr(
             elif len(value) == 1:
                 value = value[0]
             else:
-                exprs = [
-                    property_to_expr(
-                        Property(
-                            type=property.type,
-                            key=property.key,
-                            operator=property.operator,
-                            value=v,
-                        ),
-                        team,
-                        scope,
+                if operator in [PropertyOperator.exact, PropertyOperator.is_not]:
+                    op = (
+                        ast.CompareOperationOp.In
+                        if operator == PropertyOperator.exact
+                        else ast.CompareOperationOp.NotIn
                     )
-                    for v in value
-                ]
-                if (
-                    operator == PropertyOperator.is_not
-                    or operator == PropertyOperator.not_icontains
-                    or operator == PropertyOperator.not_regex
-                ):
-                    return ast.And(exprs=exprs)
-                return ast.Or(exprs=exprs)
+
+                    return ast.CompareOperation(
+                        op=op,
+                        left=ast.Field(chain=["properties", property.key]),
+                        right=ast.Tuple(exprs=[ast.Constant(value=v) for v in value]),
+                    )
+                else:
+                    exprs = [
+                        property_to_expr(
+                            Property(
+                                type=property.type,
+                                key=property.key,
+                                operator=property.operator,
+                                value=v,
+                            ),
+                            team,
+                            scope,
+                        )
+                        for v in value
+                    ]
+                    if operator == PropertyOperator.not_icontains or operator == PropertyOperator.not_regex:
+                        return ast.And(exprs=exprs)
+                    return ast.Or(exprs=exprs)
 
         chain = ["person", "properties"] if property.type == "person" and scope != "person" else ["properties"]
         field = ast.Field(chain=chain + [property.key])

diff --git a/posthog/hogql/test/test_property.py b/posthog/hogql/test/test_property.py
@@ -163,7 +163,7 @@ def test_property_to_expr_event_list(self):
         # positive
         self.assertEqual(
             self._property_to_expr({"type": "event", "key": "a", "value": ["b", "c"], "operator": "exact"}),
-            self._parse_expr("properties.a = 'b' or properties.a = 'c'"),
+            self._parse_expr("properties.a IN ('b', 'c')"),
         )
         self.assertEqual(
             self._property_to_expr(
@@ -183,7 +183,7 @@ def test_property_to_expr_event_list(self):
         # negative
         self.assertEqual(
             self._property_to_expr({"type": "event", "key": "a", "value": ["b", "c"], "operator": "is_not"}),
-            self._parse_expr("properties.a != 'b' and properties.a != 'c'"),
+            self._parse_expr("properties.a NOT IN ('b', 'c')"),
         )
         self.assertEqual(
             self._property_to_expr(