feat: switch default duration (#25922)

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
PostHog · Oct 31, 2024 · 99c8ae7 · 99c8ae7
1 parent e8d88aa
commit 99c8ae7
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/frontend/__snapshots__/scenes-app-sidepanels--side-panel-docs--dark.png b/frontend/__snapshots__/scenes-app-sidepanels--side-panel-docs--dark.png
diff --git a/frontend/__snapshots__/scenes-app-sidepanels--side-panel-docs--light.png b/frontend/__snapshots__/scenes-app-sidepanels--side-panel-docs--light.png
diff --git a/frontend/src/scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic.test.ts b/frontend/src/scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic.test.ts
@@ -525,7 +525,7 @@ describe('sessionRecordingsPlaylistLogic', () => {
                     filters: {
                         date_from: '-3d',
                         date_to: null,
-                        duration: [{ key: 'duration', operator: 'gt', type: 'recording', value: 1 }],
+                        duration: [{ key: 'active_seconds', operator: 'gt', type: 'recording', value: 5 }],
                         filter_group: {
                             type: FilterLogicalOperator.And,
                             values: [
@@ -793,10 +793,10 @@ describe('sessionRecordingsPlaylistLogic', () => {
                 filter_test_accounts: false,
                 having_predicates: [
                     {
-                        key: 'duration',
+                        key: 'active_seconds',
                         operator: 'gt',
                         type: 'recording',
-                        value: 1,
+                        value: 5,
                     },
                 ],
                 kind: 'RecordingsQuery',
@@ -815,10 +815,10 @@ describe('sessionRecordingsPlaylistLogic', () => {
                 date_to: null,
                 duration: [
                     {
-                        key: 'duration',
+                        key: 'active_seconds',
                         operator: 'gt',
                         type: 'recording',
-                        value: 1,
+                        value: 5,
                     },
                 ],
                 filter_group: {

diff --git a/frontend/src/scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic.ts b/frontend/src/scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic.ts
@@ -72,8 +72,8 @@ export const PINNED_RECORDINGS_LIMIT = 100 // NOTE: This is high but avoids the
 
 export const defaultRecordingDurationFilter: RecordingDurationFilter = {
     type: PropertyFilterType.Recording,
-    key: 'duration',
-    value: 1,
+    key: 'active_seconds',
+    value: 5,
     operator: PropertyOperator.GreaterThan,
 }
 
@@ -199,7 +199,7 @@ export function convertLegacyFiltersToUniversalFilters(
                 ? DEFAULT_RECORDING_FILTERS['filter_test_accounts']
                 : filters.filter_test_accounts,
         duration: filters.session_recording_duration
-            ? [{ ...filters.session_recording_duration, key: filters.duration_type_filter || 'duration' }]
+            ? [{ ...filters.session_recording_duration, key: filters.duration_type_filter || 'active_seconds' }]
             : DEFAULT_RECORDING_FILTERS['duration'],
         filter_group: {
             type: FilterLogicalOperator.And,