Skip to content

Commit

Permalink
Force Compare to be passed explicitly
Browse files Browse the repository at this point in the history
This is complicated because `self.query` doesn't always have `self.query.compare`, so this would fail a lot of tests
  • Loading branch information
rafaeelaudibert committed Dec 2, 2024
1 parent 8f1486d commit 9642d1e
Showing 1 changed file with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,7 @@ def property_filters_without_pathname(
) -> list[Union[EventPropertyFilter, PersonPropertyFilter, SessionPropertyFilter]]:
return [p for p in self.query.properties if p.key != "$pathname"]

def period_aggregate(self, function_name, column_name, start, end, alias=None, params=None, compare=None):
compare = self.query.compare if compare is None else compare

def period_aggregate(self, function_name, column_name, start, end, alias=None, params=None, compare=False):
if compare:
expr = ast.Call(
name=function_name + "If",
Expand Down

0 comments on commit 9642d1e

Please sign in to comment.