wip

PostHog · Aug 9, 2024 · 943b595 · 943b595
1 parent a299792
commit 943b595
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.storybook/test-runner.ts b/.storybook/test-runner.ts
@@ -80,8 +80,9 @@ module.exports = {
     async preVisit(page, context) {
         const storyContext = await getStoryContext(page, context)
         const viewport = storyContext.parameters?.testOptions?.viewport || DEFAULT_VIEWPORT
+        const viewPortChange = page.waitForFunction(() => window.innerWidth === viewport.width)
         await page.setViewportSize(viewport)
-        await page.waitForFunction(() => window.innerWidth == viewport.width)
+        await viewPortChange
     },
     async postVisit(page, context) {
         ATTEMPT_COUNT_PER_ID[context.id] = (ATTEMPT_COUNT_PER_ID[context.id] || 0) + 1
@@ -95,8 +96,9 @@ module.exports = {
             // When retrying, resize the viewport and then resize again to default,
             // just in case the retry is due to a useResizeObserver fail
             await page.setViewportSize({ width: 1920, height: 1080 })
+            const viewPortChange = page.waitForFunction(() => window.innerWidth === viewport.width)
             await page.setViewportSize(viewport)
-            await page.waitForFunction(() => window.innerWidth == viewport.width)
+            await viewPortChange
         }
         const browserContext = page.context()
         const { snapshotBrowsers = ['chromium'] } = storyContext.parameters?.testOptions ?? {}

diff --git a/playwright.config.ts b/playwright.config.ts
@@ -47,6 +47,11 @@ export default defineConfig({
             name: 'chromium',
             use: {
                 ...devices['Desktop Chrome'],
+                viewport: null,
+                launchOptions: {
+                    ...devices['Desktop Chrome']['launchOptions'],
+                    args: ['--window-size=1280,720'],
+                },
             },
         },