feat: hide integrated persons / personfull addon (#21238)

* hide addon from billing page * hide from plan comparison and don't include in upgrade link * rename * fix types * fix type
PostHog · Mar 29, 2024 · 92e17ce · 92e17ce
1 parent 5e3c3b9
commit 92e17ce
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 4 deletions.
diff --git a/frontend/src/mocks/fixtures/_billing_v2.tsx b/frontend/src/mocks/fixtures/_billing_v2.tsx
@@ -333,6 +333,7 @@ export const billingJson: BillingV2Type = {
             addons: [
                 {
                     name: 'Group analytics',
+                    inclusion_only: false,
                     description:
                         'Associate events with a group or entity - such as a company, community, or project. Analyze these events as if they were sent by that entity itself. Great for B2B, marketplaces, and more.',
                     price_description: null,
@@ -512,6 +513,7 @@ export const billingJson: BillingV2Type = {
                 },
                 {
                     name: 'Data pipelines',
+                    inclusion_only: false,
                     description:
                         'Get your PostHog data into your data warehouse or other tools like BigQuery, Redshift, Customer.io, and more.',
                     price_description: null,

diff --git a/frontend/src/scenes/billing/Billing.stories.tsx b/frontend/src/scenes/billing/Billing.stories.tsx
@@ -117,6 +117,7 @@ export const BillingUnsubscribeModal_DataPipelines = (): JSX.Element => {
             plans: [],
             usage_key: '',
             contact_support: false,
+            inclusion_only: false,
         },
     ]
 

diff --git a/frontend/src/scenes/billing/BillingProduct.tsx b/frontend/src/scenes/billing/BillingProduct.tsx
@@ -586,9 +586,11 @@ export const BillingProduct = ({ product }: { product: BillingProductV2Type }):
                         <div className="pb-8">
                             <h4 className="my-4">Addons</h4>
                             <div className="gap-y-4 flex flex-col">
-                                {product.addons.map((addon, i) => {
-                                    return <BillingProductAddon key={i} addon={addon} />
-                                })}
+                                {product.addons
+                                    .filter((addon) => !addon.inclusion_only)
+                                    .map((addon, i) => {
+                                        return <BillingProductAddon key={i} addon={addon} />
+                                    })}
                             </div>
                         </div>
                     )}

diff --git a/frontend/src/scenes/billing/PlanComparison.tsx b/frontend/src/scenes/billing/PlanComparison.tsx
@@ -288,6 +288,7 @@ export const PlanComparison = ({
                 )}
                 {includeAddons &&
                     product.addons?.map((addon) => {
+                        // TODO: integrated_persons addon will show up here when we add a price plan. Make sure this can handle it.
                         return addon.tiered ? (
                             <tr key={addon.name + 'pricing-row'} className="PlanTable__tr__border">
                                 <th scope="row">

diff --git a/frontend/src/scenes/billing/billing-utils.ts b/frontend/src/scenes/billing/billing-utils.ts
@@ -169,7 +169,11 @@ export const getUpgradeProductLink = (
     url += `${product.type}:${upgradeToPlanKey},`
     if (includeAddons && product.addons?.length) {
         for (const addon of product.addons) {
-            if (addon.plans?.[0]?.plan_key) {
+            if (
+                // TODO: this breaks if we support multiple plans per addon due to just grabbing the first plan
+                addon.plans?.[0]?.plan_key &&
+                !addon.inclusion_only
+            ) {
                 url += `${addon.type}:${addon.plans[0].plan_key},`
             }
         }

diff --git a/frontend/src/types.ts b/frontend/src/types.ts
@@ -1427,6 +1427,7 @@ export interface BillingProductV2AddonType {
     subscribed: boolean
     // sometimes addons are included with the base product, but they aren't subscribed individually
     included_with_main_product?: boolean
+    inclusion_only: boolean | null
     contact_support: boolean | null
     unit: string | null
     unit_amount_usd: string | null