fix(hogql): throw error for missing actions in funnels (#20867)

PostHog · Mar 12, 2024 · 926d860 · 926d860
1 parent 2bd43f2
commit 926d860
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/posthog/hogql_queries/insights/funnels/funnel_event_query.py b/posthog/hogql_queries/insights/funnels/funnel_event_query.py
@@ -134,8 +134,11 @@ def _entity_expr(self, skip_entity_filter: bool) -> ast.Expr | None:
             if isinstance(node, EventsNode) or isinstance(node, FunnelExclusionEventsNode):
                 events.add(node.event)
             elif isinstance(node, ActionsNode) or isinstance(node, FunnelExclusionActionsNode):
-                action = Action.objects.get(pk=int(node.id), team=team)
-                events.update(action.get_step_events())
+                try:
+                    action = Action.objects.get(pk=int(node.id), team=team)
+                    events.update(action.get_step_events())
+                except Action.DoesNotExist:
+                    raise ValidationError(f"Action ID {node.id} does not exist!")
             else:
                 raise ValidationError("Series and exclusions must be compose of action and event nodes")