fix(insights): Increase max AST size for funnel time to convert (#20628)

PostHog · Feb 29, 2024 · 926b403 · 926b403
1 parent 30bdd3e
commit 926b403
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 8 deletions.
diff --git a/posthog/api/test/__snapshots__/test_insight_funnels.ambr b/posthog/api/test/__snapshots__/test_insight_funnels.ambr
@@ -122,7 +122,8 @@
     (SELECT histogram_from_seconds + number * bin_width_seconds AS bin_from_seconds
      FROM system.numbers
      LIMIT ifNull(bin_count, 0) + 1) fill USING (bin_from_seconds)
-  ORDER BY bin_from_seconds
+  ORDER BY bin_from_seconds SETTINGS max_ast_elements=1000000,
+                                     max_expanded_ast_elements=1000000
   '''
 # ---
 # name: ClickhouseTestFunnelTypes.test_funnel_time_to_convert_auto_bins_strict
@@ -229,7 +230,8 @@
     (SELECT histogram_from_seconds + number * bin_width_seconds AS bin_from_seconds
      FROM system.numbers
      LIMIT ifNull(bin_count, 0) + 1) fill USING (bin_from_seconds)
-  ORDER BY bin_from_seconds
+  ORDER BY bin_from_seconds SETTINGS max_ast_elements=1000000,
+                                     max_expanded_ast_elements=1000000
   '''
 # ---
 # name: ClickhouseTestFunnelTypes.test_funnel_time_to_convert_auto_bins_unordered
@@ -438,6 +440,7 @@
     (SELECT histogram_from_seconds + number * bin_width_seconds AS bin_from_seconds
      FROM system.numbers
      LIMIT ifNull(bin_count, 0) + 1) fill USING (bin_from_seconds)
-  ORDER BY bin_from_seconds
+  ORDER BY bin_from_seconds SETTINGS max_ast_elements=1000000,
+                                     max_expanded_ast_elements=1000000
   '''
 # ---
diff --git a/posthog/queries/funnels/funnel_time_to_convert.py b/posthog/queries/funnels/funnel_time_to_convert.py
@@ -107,6 +107,7 @@ def get_query(self) -> str:
             ) fill
             USING (bin_from_seconds)
             ORDER BY bin_from_seconds
+            SETTINGS max_ast_elements=1000000, max_expanded_ast_elements=1000000
         """
 
         return query
diff --git a/posthog/queries/funnels/test/__snapshots__/test_funnel_time_to_convert.ambr b/posthog/queries/funnels/test/__snapshots__/test_funnel_time_to_convert.ambr
@@ -122,7 +122,8 @@
     (SELECT histogram_from_seconds + number * bin_width_seconds AS bin_from_seconds
      FROM system.numbers
      LIMIT ifNull(bin_count, 0) + 1) fill USING (bin_from_seconds)
-  ORDER BY bin_from_seconds
+  ORDER BY bin_from_seconds SETTINGS max_ast_elements=1000000,
+                                     max_expanded_ast_elements=1000000
   '''
 # ---
 # name: TestFunnelTimeToConvert.test_auto_bin_count_total
@@ -248,7 +249,8 @@
     (SELECT histogram_from_seconds + number * bin_width_seconds AS bin_from_seconds
      FROM system.numbers
      LIMIT ifNull(bin_count, 0) + 1) fill USING (bin_from_seconds)
-  ORDER BY bin_from_seconds
+  ORDER BY bin_from_seconds SETTINGS max_ast_elements=1000000,
+                                     max_expanded_ast_elements=1000000
   '''
 # ---
 # name: TestFunnelTimeToConvert.test_auto_bin_count_total.1
@@ -374,7 +376,8 @@
     (SELECT histogram_from_seconds + number * bin_width_seconds AS bin_from_seconds
      FROM system.numbers
      LIMIT ifNull(bin_count, 0) + 1) fill USING (bin_from_seconds)
-  ORDER BY bin_from_seconds
+  ORDER BY bin_from_seconds SETTINGS max_ast_elements=1000000,
+                                     max_expanded_ast_elements=1000000
   '''
 # ---
 # name: TestFunnelTimeToConvert.test_basic_strict
@@ -481,7 +484,8 @@
     (SELECT histogram_from_seconds + number * bin_width_seconds AS bin_from_seconds
      FROM system.numbers
      LIMIT ifNull(bin_count, 0) + 1) fill USING (bin_from_seconds)
-  ORDER BY bin_from_seconds
+  ORDER BY bin_from_seconds SETTINGS max_ast_elements=1000000,
+                                     max_expanded_ast_elements=1000000
   '''
 # ---
 # name: TestFunnelTimeToConvert.test_basic_unordered
@@ -690,6 +694,7 @@
     (SELECT histogram_from_seconds + number * bin_width_seconds AS bin_from_seconds
      FROM system.numbers
      LIMIT ifNull(bin_count, 0) + 1) fill USING (bin_from_seconds)
-  ORDER BY bin_from_seconds
+  ORDER BY bin_from_seconds SETTINGS max_ast_elements=1000000,
+                                     max_expanded_ast_elements=1000000
   '''
 # ---