fix: Return no content on password reset (#21003)

PostHog · Mar 19, 2024 · 921d208 · 921d208
1 parent dbee1bb
commit 921d208
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/posthog/api/authentication.py b/posthog/api/authentication.py
@@ -179,6 +179,10 @@ def create(self, request: Request, *args: Any, **kwargs: Any) -> Response:
         """
         response = super().create(request, *args, **kwargs)
         response.status_code = getattr(self, "SUCCESS_STATUS_CODE", status.HTTP_200_OK)
+
+        if response.status_code == status.HTTP_204_NO_CONTENT:
+            response.data = None
+
         return response
 
 

diff --git a/posthog/api/test/test_authentication.py b/posthog/api/test/test_authentication.py
@@ -317,6 +317,7 @@ def test_anonymous_user_can_request_password_reset(self, mock_capture):
             response = self.client.post("/api/reset/", {"email": self.CONFIG_EMAIL})
         self.assertEqual(response.status_code, status.HTTP_204_NO_CONTENT)
         self.assertEqual(response.content.decode(), "")
+        self.assertEqual(response.headers["Content-Length"], "0")
 
         user: User = User.objects.get(email=self.CONFIG_EMAIL)
         self.assertEqual(