Skip to content

Commit

Permalink
refactor: remove redundant references
Browse files Browse the repository at this point in the history
  • Loading branch information
hamirmahal committed Oct 14, 2024
1 parent c2a9b1f commit 91a736b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions funnel-udf/src/steps.rs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const DEFAULT_ENTERED_TIMESTAMP: EnteredTimestamp = EnteredTimestamp {
};

pub fn process_line(line: &str) -> Value {
let args = parse_args(&line);
let args = parse_args(line);
let mut aggregate_funnel_row = AggregateFunnelRow {
results: Vec::with_capacity(args.prop_vals.len()),
breakdown_step: Option::None,
Expand Down Expand Up @@ -113,7 +113,7 @@ impl AggregateFunnelRow {
if !self.process_event(
args,
&mut vars,
&events_with_same_timestamp[0],
events_with_same_timestamp[0],
prop_val,
false,
) {
Expand Down Expand Up @@ -151,7 +151,7 @@ impl AggregateFunnelRow {

// Run exclusions, if they exist, then run matching events.
for event in sorted_events {
if !self.process_event(args, &mut vars, &event, &prop_val, true) {
if !self.process_event(args, &mut vars, &event, prop_val, true) {
return;
}
}
Expand Down
4 changes: 2 additions & 2 deletions funnel-udf/src/trends.rs
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ const DEFAULT_ENTERED_TIMESTAMP: EnteredTimestamp = EnteredTimestamp {
};

pub fn process_line(line: &str) -> Value {
let args = parse_args(&line);
let args = parse_args(line);
let mut aggregate_funnel_row = AggregateFunnelRow {
results: HashMap::new(),
breakdown_step: Option::None,
Expand Down Expand Up @@ -105,7 +105,7 @@ impl AggregateFunnelRow {
for (_timestamp, events_with_same_timestamp) in &filtered_events {
let events_with_same_timestamp: Vec<_> = events_with_same_timestamp.collect();
for event in events_with_same_timestamp {
if !self.process_event(args, &mut vars, &event, prop_val) {
if !self.process_event(args, &mut vars, event, prop_val) {
return;
}
}
Expand Down

0 comments on commit 91a736b

Please sign in to comment.