chore: Enable Android/RN/iOS code snippets for feature flags (#19482)

PostHog · Dec 22, 2023 · 915cf58 · 915cf58
1 parent 2944c06
commit 915cf58
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 4 deletions.
diff --git a/...p-feature-flags-code-examples--code-instructionsi-os-with-multivariate-flag.png b/...p-feature-flags-code-examples--code-instructionsi-os-with-multivariate-flag.png
diff --git a/frontend/src/scenes/feature-flags/FeatureFlagCodeOptions.tsx b/frontend/src/scenes/feature-flags/FeatureFlagCodeOptions.tsx
@@ -118,7 +118,16 @@ export const OPTIONS: InstructionOption[] = [
 
 export const LOCAL_EVALUATION_LIBRARIES: string[] = [SDKKey.NODE_JS, SDKKey.PYTHON, SDKKey.RUBY, SDKKey.PHP, SDKKey.GO]
 
-export const PAYLOAD_LIBRARIES: string[] = [SDKKey.JS_WEB, SDKKey.NODE_JS, SDKKey.PYTHON, SDKKey.RUBY, SDKKey.REACT]
+export const PAYLOAD_LIBRARIES: string[] = [
+    SDKKey.JS_WEB,
+    SDKKey.NODE_JS,
+    SDKKey.PYTHON,
+    SDKKey.RUBY,
+    SDKKey.REACT,
+    SDKKey.ANDROID,
+    SDKKey.REACT_NATIVE,
+    SDKKey.IOS,
+]
 
 export const BOOTSTRAPPING_OPTIONS: InstructionOption[] = [
     {

diff --git a/frontend/src/scenes/feature-flags/FeatureFlagSnippets.tsx b/frontend/src/scenes/feature-flags/FeatureFlagSnippets.tsx
@@ -312,8 +312,17 @@ if ${conditional}:
     )
 }
 
-export function AndroidSnippet({ flagKey, multivariant }: FeatureFlagSnippet): JSX.Element {
+export function AndroidSnippet({ flagKey, multivariant, payload }: FeatureFlagSnippet): JSX.Element {
     const clientSuffix = 'PostHog.'
+
+    if (payload) {
+        return (
+            <CodeSnippet language={Language.Kotlin} wrap>
+                {`${clientSuffix}getFeatureFlagPayload("${flagKey}")`}
+            </CodeSnippet>
+        )
+    }
+
     const flagFunction = multivariant ? 'getFeatureFlag' : 'isFeatureEnabled'
 
     const variantSuffix = multivariant ? ` == "example-variant"` : ''
@@ -327,8 +336,17 @@ export function AndroidSnippet({ flagKey, multivariant }: FeatureFlagSnippet): J
     )
 }
 
-export function iOSSnippet({ flagKey, multivariant }: FeatureFlagSnippet): JSX.Element {
+export function iOSSnippet({ flagKey, multivariant, payload }: FeatureFlagSnippet): JSX.Element {
     const clientSuffix = 'posthog.'
+
+    if (payload) {
+        return (
+            <CodeSnippet language={Language.Swift} wrap>
+                {`${clientSuffix}getFeatureFlagStringPayload("${flagKey}", defaultValue: "myDefaultValue")`}
+            </CodeSnippet>
+        )
+    }
+
     const flagFunction = multivariant ? 'getFeatureFlag' : 'isFeatureEnabled'
 
     const variantSuffix = multivariant ? ` == 'example-variant'` : ''
@@ -344,8 +362,17 @@ if (${clientSuffix}${flagFunction}('${flagKey}') ${variantSuffix}) {
     )
 }
 
-export function ReactNativeSnippet({ flagKey, multivariant }: FeatureFlagSnippet): JSX.Element {
+export function ReactNativeSnippet({ flagKey, multivariant, payload }: FeatureFlagSnippet): JSX.Element {
     const clientSuffix = 'posthog.'
+
+    if (payload) {
+        return (
+            <CodeSnippet language={Language.JSX} wrap>
+                {`${clientSuffix}getFeatureFlagPayload('${flagKey}'`}
+            </CodeSnippet>
+        )
+    }
+
     const flagFunction = multivariant ? 'getFeatureFlag' : 'isFeatureEnabled'
 
     const variantSuffix = multivariant ? ` == 'example-variant'` : ''