chore: remove unused empty state (#17529)

PostHog · Sep 19, 2023 · 8ff764b · 8ff764b
1 parent bb61ee1
commit 8ff764b
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 17 deletions.
diff --git a/frontend/src/scenes/notebooks/Notebook/Editor.tsx b/frontend/src/scenes/notebooks/Notebook/Editor.tsx
@@ -191,7 +191,6 @@ export function Editor({
                 setSelection: (position: number) => editor.commands.setNodeSelection(position),
                 focus: (position: EditorFocusPosition) => queueMicrotask(() => editor.commands.focus(position)),
                 destroy: () => editor.destroy(),
-                isEmpty: () => editor.isEmpty,
                 deleteRange: (range: EditorRange) => editor.chain().focus().deleteRange(range),
                 insertContent: (content: JSONContent) => editor.chain().insertContent(content).focus().run(),
                 insertContentAfterNode: (position: number, content: JSONContent) => {

diff --git a/frontend/src/scenes/notebooks/Notebook/Notebook.tsx b/frontend/src/scenes/notebooks/Notebook/Notebook.tsx
@@ -26,7 +26,7 @@ const PLACEHOLDER_TITLES = ['Release notes', 'Product roadmap', 'Meeting notes',
 
 export function Notebook({ shortId, editable = false, initialAutofocus = null }: NotebookProps): JSX.Element {
     const logic = notebookLogic({ shortId })
-    const { notebook, content, notebookLoading, isEmpty, editor, conflictWarningVisible } = useValues(logic)
+    const { notebook, content, notebookLoading, editor, conflictWarningVisible } = useValues(logic)
     const { setEditor, onEditorUpdate, duplicateNotebook, loadNotebook, setEditable, onEditorSelectionUpdate } =
         useActions(logic)
     const { isExpanded } = useValues(notebookSettingsLogic)
@@ -57,14 +57,6 @@ export function Notebook({ shortId, editable = false, initialAutofocus = null }:
         return <NotebookLoadingState />
     } else if (!notebook) {
         return <NotFound object="notebook" />
-    } else if (isEmpty && !editable) {
-        return (
-            <div className="NotebookEditor">
-                <h1>
-                    <i>Untitled</i>
-                </h1>
-            </div>
-        )
     }
 
     return (

diff --git a/frontend/src/scenes/notebooks/Notebook/notebookLogic.ts b/frontend/src/scenes/notebooks/Notebook/notebookLogic.ts
@@ -292,12 +292,6 @@ export const notebookLogic = kea<notebookLogicType>([
                 return contentTitle || notebook?.title || 'Untitled'
             },
         ],
-        isEmpty: [
-            (s) => [s.editor, s.content],
-            (editor: NotebookEditor): boolean => {
-                return editor?.isEmpty() || false
-            },
-        ],
         syncStatus: [
             (s) => [s.notebook, s.notebookLoading, s.localContent, s.isLocalOnly],
             (notebook, notebookLoading, localContent, isLocalOnly): NotebookSyncStatus => {

diff --git a/frontend/src/scenes/notebooks/Notebook/utils.ts b/frontend/src/scenes/notebooks/Notebook/utils.ts
@@ -63,7 +63,6 @@ export interface NotebookEditor {
     setSelection: (position: number) => void
     focus: (position: EditorFocusPosition) => void
     destroy: () => void
-    isEmpty: () => boolean
     deleteRange: (range: EditorRange) => EditorCommands
     insertContent: (content: JSONContent) => void
     insertContentAfterNode: (position: number, content: JSONContent) => void