refactor: rename logic file to be more generic

PostHog · Oct 8, 2024 · 8d217ae · 8d217ae
1 parent da5211c
commit 8d217ae
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 10 deletions.
diff --git a/frontend/src/scenes/settings/environment/SessionRecordingSettings.tsx b/frontend/src/scenes/settings/environment/SessionRecordingSettings.tsx
@@ -23,7 +23,7 @@ import { SESSION_REPLAY_MINIMUM_DURATION_OPTIONS } from 'lib/constants'
 import { IconCancel, IconSelectEvents } from 'lib/lemon-ui/icons'
 import { LemonLabel } from 'lib/lemon-ui/LemonLabel/LemonLabel'
 import { objectsEqual } from 'lib/utils'
-import { sessionReplayLinkedFlagLogic } from 'scenes/settings/environment/sessionReplayLinkedFlagLogic'
+import { sessionReplayIngestionControlLogic } from 'scenes/settings/environment/sessionReplayIngestionControlLogic'
 import { teamLogic } from 'scenes/teamLogic'
 import { userLogic } from 'scenes/userLogic'
 
@@ -259,7 +259,9 @@ function LinkedFlagSelector(): JSX.Element | null {
 
     const featureFlagRecordingFeatureEnabled = hasAvailableFeature(AvailableFeature.REPLAY_FEATURE_FLAG_BASED_RECORDING)
 
-    const logic = sessionReplayLinkedFlagLogic({ id: currentTeam?.session_recording_linked_flag?.id || null })
+    const logic = sessionReplayIngestionControlLogic({
+        linkedFeatureFlagId: currentTeam?.session_recording_linked_flag?.id || null,
+    })
     const { linkedFlag, featureFlagLoading, flagHasVariants } = useValues(logic)
     const { selectFeatureFlag } = useActions(logic)
 

diff --git a/...vironment/sessionReplayLinkedFlagLogic.ts → ...ent/sessionReplayIngestionControlLogic.ts b/...vironment/sessionReplayLinkedFlagLogic.ts → ...ent/sessionReplayIngestionControlLogic.ts
@@ -7,14 +7,14 @@ import { teamLogic } from 'scenes/teamLogic'
 
 import { FeatureFlagBasicType } from '~/types'
 
-import type { sessionReplayLinkedFlagLogicType } from './sessionReplayLinkedFlagLogicType'
+import type { sessionReplayIngestionControlLogicType } from './sessionReplayIngestionControlLogicType'
 
-export interface ReplayLinkedFlagLogicProps {
-    id: number | null
+export interface ReplayIngestionControlLogicProps {
+    linkedFeatureFlagId: number | null
 }
 
-export const sessionReplayLinkedFlagLogic = kea<sessionReplayLinkedFlagLogicType>([
-    path(['scenes', 'settings', 'project', 'sessionReplayLinkedFlagLogic']),
+export const sessionReplayIngestionControlLogic = kea<sessionReplayIngestionControlLogicType>([
+    path(['scenes', 'settings', 'project', 'sessionReplayIngestionControlLogic']),
     actions({
         selectFeatureFlag: (flag: FeatureFlagBasicType) => ({ flag }),
     }),
@@ -27,12 +27,12 @@ export const sessionReplayLinkedFlagLogic = kea<sessionReplayLinkedFlagLogicType
             },
         ],
     }),
-    props({} as ReplayLinkedFlagLogicProps),
+    props({} as ReplayIngestionControlLogicProps),
     loaders(({ props }) => ({
         featureFlag: {
             loadFeatureFlag: async () => {
-                if (props.id) {
-                    const retrievedFlag = await api.featureFlags.get(props.id)
+                if (props.linkedFeatureFlagId) {
+                    const retrievedFlag = await api.featureFlags.get(props.linkedFeatureFlagId)
                     return variantKeyToIndexFeatureFlagPayloads(retrievedFlag)
                 }
                 return null