feat(editor-3000): add visualization tab (#26268)

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
PostHog · Dec 3, 2024 · 8b60590 · 8b60590
1 parent 5830eec
commit 8b60590
Show file tree

Hide file tree

Showing 10 changed files with 430 additions and 151 deletions.
diff --git a/frontend/src/layout/navigation-3000/components/Navbar.tsx b/frontend/src/layout/navigation-3000/components/Navbar.tsx
@@ -59,7 +59,7 @@ export function Navbar(): JSX.Element {
                                                     ? () => {
                                                           if (
                                                               activeNavbarItemId === item.identifier &&
-                                                              isSidebarShown
+                                                              !isSidebarShown
                                                           ) {
                                                               hideSidebar()
                                                           } else {

diff --git a/frontend/src/layout/navigation-3000/navigationLogic.tsx b/frontend/src/layout/navigation-3000/navigationLogic.tsx
@@ -512,7 +512,7 @@ export const navigation3000Logic = kea<navigation3000LogicType>([
                         featureFlags[FEATURE_FLAGS.SQL_EDITOR]
                             ? {
                                   identifier: Scene.SQLEditor,
-                                  label: 'Data warehouse',
+                                  label: 'Data warehouse 3000',
                                   icon: <IconServer />,
                                   to: urls.sqlEditor(),
                                   logic: editorSidebarLogic,

diff --git a/frontend/src/queries/nodes/DataNode/dataNodeLogic.ts b/frontend/src/queries/nodes/DataNode/dataNodeLogic.ts
@@ -198,7 +198,6 @@ export const dataNodeLogic = kea<dataNodeLogicType>([
                     const methodOptions: ApiMethodOptions = {
                         signal: cache.abortController.signal,
                     }
-
                     try {
                         const response = await concurrencyController.run({
                             debugTag: query.kind,

diff --git a/frontend/src/queries/nodes/DataVisualization/DataVisualization.tsx b/frontend/src/queries/nodes/DataVisualization/DataVisualization.tsx
@@ -46,7 +46,7 @@ import { variablesLogic } from './Components/Variables/variablesLogic'
 import { dataVisualizationLogic, DataVisualizationLogicProps } from './dataVisualizationLogic'
 import { displayLogic } from './displayLogic'
 
-interface DataTableVisualizationProps {
+export interface DataTableVisualizationProps {
     uniqueKey?: string | number
     query: DataVisualizationNode
     setQuery: (query: DataVisualizationNode) => void

diff --git a/frontend/src/queries/nodes/DataVisualization/dataVisualizationLogic.ts b/frontend/src/queries/nodes/DataVisualization/dataVisualizationLogic.ts
@@ -580,9 +580,10 @@ export const dataVisualizationLogic = kea<dataVisualizationLogicType>([
             },
         ],
         presetChartHeight: [
-            (state) => [state.dashboardId],
-            (dashboardId) => {
-                return !dashboardId
+            (state, props) => [props.key, state.dashboardId],
+            (key, dashboardId) => {
+                // Key for SQL editor based visiaulizations
+                return !key.includes('SQLEditorScene') && !dashboardId
             },
         ],
         sourceFeatures: [(_, props) => [props.query], (query): Set<QueryFeature> => getQueryFeatures(query.source)],