feat: Enable brotli compression in S3 batch exports configuration (#1…

…7463)
PostHog · Sep 15, 2023 · 8ab153f · 8ab153f
1 parent f438e59
commit 8ab153f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/frontend/src/scenes/batch_exports/BatchExportEditForm.tsx b/frontend/src/scenes/batch_exports/BatchExportEditForm.tsx
@@ -190,6 +190,7 @@ export function BatchExportsEditForm(props: BatchExportsEditLogicProps): JSX.Ele
                                             <LemonSelect
                                                 options={[
                                                     { value: 'gzip', label: 'gzip' },
+                                                    { value: 'brotli', label: 'brotli' },
                                                     { value: null, label: 'No compression' },
                                                 ]}
                                             />

diff --git a/posthog/temporal/tests/batch_exports/test_s3_batch_export_workflow.py b/posthog/temporal/tests/batch_exports/test_s3_batch_export_workflow.py
@@ -444,7 +444,7 @@ async def test_s3_export_workflow_with_minio_bucket(
 @pytest.mark.asyncio
 @pytest.mark.parametrize(
     "interval,compression,encryption,exclude_events",
-    itertools.product(["hour", "day"], [None, "gzip", "brotli"], [None, "AES256"], [None, ["test-exclude"]]),
+    itertools.product(["hour", "day"], [None, "gzip", "brotli"], [None, "AES256", "aws:kms"], [None, ["test-exclude"]]),
 )
 async def test_s3_export_workflow_with_s3_bucket(interval, compression, encryption, exclude_events):
     """Test S3 Export Workflow end-to-end by using an S3 bucket.
@@ -457,6 +457,7 @@ async def test_s3_export_workflow_with_s3_bucket(interval, compression, encrypti
     records to the S3 bucket.
     """
     bucket_name = os.getenv("S3_TEST_BUCKET")
+    kms_key_id = os.getenv("S3_TEST_KMS_KEY_ID")
     prefix = f"posthog-events-{str(uuid4())}"
     destination_data = {
         "type": "S3",
@@ -469,6 +470,7 @@ async def test_s3_export_workflow_with_s3_bucket(interval, compression, encrypti
             "compression": compression,
             "exclude_events": exclude_events,
             "encryption": encryption,
+            "kms_key_id": kms_key_id if encryption == "aws:kms" else None,
         },
     }