chore: remove other products step (#20243)

remove other products step
PostHog · Feb 13, 2024 · 81a1473 · 81a1473
1 parent a9ca9c2
commit 81a1473
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 61 deletions.
diff --git a/frontend/src/scenes/onboarding/Onboarding.tsx b/frontend/src/scenes/onboarding/Onboarding.tsx
@@ -10,7 +10,6 @@ import { AvailableFeature, ProductKey } from '~/types'
 import { OnboardingBillingStep } from './OnboardingBillingStep'
 import { OnboardingInviteTeammates } from './OnboardingInviteTeammates'
 import { onboardingLogic, OnboardingStepKey } from './onboardingLogic'
-import { OnboardingOtherProductsStep } from './OnboardingOtherProductsStep'
 import { OnboardingProductConfiguration } from './OnboardingProductConfiguration'
 import { ProductConfigOption } from './onboardingProductConfigurationLogic'
 import { OnboardingVerificationStep } from './OnboardingVerificationStep'
@@ -29,7 +28,7 @@ export const scene: SceneExport = {
  * Wrapper for custom onboarding content. This automatically includes billing, other products, and invite steps.
  */
 const OnboardingWrapper = ({ children }: { children: React.ReactNode }): JSX.Element => {
-    const { currentOnboardingStep, shouldShowBillingStep, shouldShowOtherProductsStep } = useValues(onboardingLogic)
+    const { currentOnboardingStep, shouldShowBillingStep } = useValues(onboardingLogic)
     const { setAllOnboardingSteps } = useActions(onboardingLogic)
     const { product } = useValues(onboardingLogic)
     const [allSteps, setAllSteps] = useState<JSX.Element[]>([])
@@ -60,10 +59,6 @@ const OnboardingWrapper = ({ children }: { children: React.ReactNode }): JSX.Ele
             const BillingStep = <OnboardingBillingStep product={product} stepKey={OnboardingStepKey.BILLING} />
             steps = [...steps, BillingStep]
         }
-        if (shouldShowOtherProductsStep) {
-            const OtherProductsStep = <OnboardingOtherProductsStep stepKey={OnboardingStepKey.OTHER_PRODUCTS} />
-            steps = [...steps, OtherProductsStep]
-        }
         const inviteTeammatesStep = <OnboardingInviteTeammates stepKey={OnboardingStepKey.INVITE_TEAMMATES} />
         steps = [...steps, inviteTeammatesStep]
         setAllSteps(steps)

diff --git a/frontend/src/scenes/onboarding/OnboardingOtherProductsStep.tsx b/frontend/src/scenes/onboarding/OnboardingOtherProductsStep.tsx
diff --git a/frontend/src/scenes/onboarding/onboardingLogic.tsx b/frontend/src/scenes/onboarding/onboardingLogic.tsx
@@ -143,22 +143,6 @@ export const onboardingLogic = kea<onboardingLogicType>([
                 return !product?.subscribed || !hasAllAddons || subscribedDuringOnboarding
             },
         ],
-        shouldShowOtherProductsStep: [
-            (s) => [s.suggestedProducts, s.isFirstProductOnboarding],
-            (suggestedProducts: BillingProductV2Type[], isFirstProductOnboarding: boolean) =>
-                suggestedProducts.length > 0 && isFirstProductOnboarding,
-        ],
-        suggestedProducts: [
-            (s) => [s.billing, s.product, s.currentTeam],
-            (billing, product, currentTeam) =>
-                billing?.products?.filter(
-                    (p) =>
-                        p.type !== product?.type &&
-                        !p.contact_support &&
-                        !p.inclusion_only &&
-                        !currentTeam?.has_completed_onboarding_for?.[p.type]
-                ) || [],
-        ],
         isStepKeyInvalid: [
             (s) => [s.stepKey, s.allOnboardingSteps, s.currentOnboardingStep],
             (stepKey: string, allOnboardingSteps: AllOnboardingSteps, currentOnboardingStep: React.ReactNode | null) =>