fix: event is sometimes null (#17784)

PostHog · Oct 4, 2023 · 7f6be48 · 7f6be48
1 parent b020987
commit 7f6be48
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/plugin-server/src/worker/ingestion/process-event.ts b/plugin-server/src/worker/ingestion/process-event.ts
@@ -359,7 +359,9 @@ export const gatherConsoleLogEvents = (
     const consoleLogEntries: ConsoleLogEntry[] = []
 
     events.forEach((event) => {
-        if (event.type === RRWebEventType.Plugin && event.data?.plugin === 'rrweb/console@1') {
+        // it should be unnecessary to check for truthiness of event here,
+        // but we've seen null in production so 🤷
+        if (!!event && event.type === RRWebEventType.Plugin && event.data?.plugin === 'rrweb/console@1') {
             const level = event.data.payload?.level
             const message = safeString(event.data.payload?.payload)
             consoleLogEntries.push({

diff --git a/plugin-server/tests/main/process-event.test.ts b/plugin-server/tests/main/process-event.test.ts
@@ -1497,6 +1497,7 @@ test('simple console log processing', () => {
                 },
             },
         },
+        null as unknown as RRWebEvent, // see https://posthog.sentry.io/issues/4525043303
     ])
     expect(consoleLogEntries).toEqual([
         {
-Original file line number
+Diff line change
@@ Expand Up / @@ -1497,6 +1497,7 @@ test('simple console log processing', () => { @@
                     },
                 },
             },
+            null as unknown as RRWebEvent, // see https://posthog.sentry.io/issues/4525043303
         ])
         expect(consoleLogEntries).toEqual([
             {
@@ Expand Down @@