feat(surveys): Link type surveys no longer require a url and can be u…

…sed as a CTA (#19320) * allow for link surveys to not require a link * make it obvious link type surveys can also double as notification * fix confirmation display * Update UI snapshots for `chromium` (2) --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
PostHog · Dec 14, 2023 · 7cc6e81 · 7cc6e81
1 parent 9f646ba
commit 7cc6e81
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 5 deletions.
diff --git a/frontend/__snapshots__/scenes-app-notebooks--recordings-playlist.png b/frontend/__snapshots__/scenes-app-notebooks--recordings-playlist.png
diff --git a/frontend/src/scenes/surveys/SurveyEditQuestionRow.tsx b/frontend/src/scenes/surveys/SurveyEditQuestionRow.tsx
@@ -130,7 +130,7 @@ export function SurveyEditQuestionGroup({ index, question }: { index: number; qu
                                 ),
                             },
                             {
-                                label: 'Link',
+                                label: 'Link/Notification',
                                 value: SurveyQuestionType.Link,
                                 tooltip: () => (
                                     <BaseAppearance

diff --git a/frontend/src/scenes/surveys/constants.tsx b/frontend/src/scenes/surveys/constants.tsx
@@ -54,7 +54,7 @@ export const defaultSurveyFieldValues = {
             },
         ],
         appearance: {
-            thankYouMessageHeader: 'Redirecting ...',
+            thankYouMessageHeader: 'Thank you for your feedback!',
         },
     },
     [SurveyQuestionType.Rating]: {

diff --git a/frontend/src/scenes/surveys/surveyLogic.tsx b/frontend/src/scenes/surveys/surveyLogic.tsx
@@ -676,9 +676,6 @@ export const surveyLogic = kea<surveyLogicType>([
                 name: !name && 'Please enter a name.',
                 questions: questions.map((question) => ({
                     question: !question.question && 'Please enter a question.',
-                    ...(question.type === SurveyQuestionType.Link
-                        ? { link: !question.link && 'Please enter a url for the link.' }
-                        : {}),
                     ...(question.type === SurveyQuestionType.Rating
                         ? {
                               display: !question.display && 'Please choose a display type.',