Skip to content

Commit

Permalink
fix: accidental add and other PR feedback (#25145)
Browse files Browse the repository at this point in the history
  • Loading branch information
raquelmsmith authored Sep 23, 2024
1 parent 3bb724e commit 7c60561
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export const SiteChooser = (): JSX.Element => {
</p>
)}
<div className="space-y-2">
{combinedSnippetAndLiveEventsHosts.concat('https://posthog.com').map((host) => (
{combinedSnippetAndLiveEventsHosts.map((host) => (
<LemonButton
key={`snippet-host-button-${host}`}
type="tertiary"
Expand Down Expand Up @@ -255,7 +255,7 @@ export const OnboardingDashboardTemplateConfigureStep = ({
{browserUrl && iframeBanner?.level != 'error' ? (
<div className="border border-1 border-border-bold rounded h-full w-full flex flex-col">
<UrlInput iframeRef={iframeRef} />
<div className="m-2 grow rounded ">
<div className="m-2 grow rounded">
<IframedToolbarBrowser iframeRef={iframeRef} userIntent="add-action" />
</div>
</div>
Expand Down
24 changes: 11 additions & 13 deletions frontend/src/toolbar/actions/ActionAttribute.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -58,19 +58,17 @@ export function ActionAttribute({
return (
<div key={attribute} className="flex flex-row gap-2 justify-between items-center">
{automaticActionCreationEnabled && (
<>
<LemonSwitch
size="small"
checked={automaticCreationIncludedPropertyKeys.includes(attribute)}
onChange={(checked) =>
checked
? addAutomaticCreationIncludedPropertyKey(attribute)
: removeAutomaticCreationIncludedPropertyKey(attribute)
}
sliderColorOverrideChecked="primary-3000-light"
sliderColorOverrideUnchecked="muted-3000-light"
/>
</>
<LemonSwitch
size="small"
checked={automaticCreationIncludedPropertyKeys.includes(attribute)}
onChange={(checked) =>
checked
? addAutomaticCreationIncludedPropertyKey(attribute)
: removeAutomaticCreationIncludedPropertyKey(attribute)
}
sliderColorOverrideChecked="primary-3000-light"
sliderColorOverrideUnchecked="muted-3000-light"
/>
)}
<div className="text-muted text-xl">{icon}</div>
<div className="grow">{text}</div>
Expand Down

0 comments on commit 7c60561

Please sign in to comment.