Skip to content

Commit

Permalink
feat(command-bar): top align command bar to prevent jumping (#19018)
Browse files Browse the repository at this point in the history
  • Loading branch information
thmsobrmlr authored Dec 1, 2023
1 parent 519415c commit 79b28d0
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 8 deletions.
Binary file modified frontend/__snapshots__/components-command-bar--actions--dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/components-command-bar--actions--light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/components-command-bar--actions.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/components-command-bar--shortcuts--dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified frontend/__snapshots__/components-command-bar--shortcuts.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
18 changes: 10 additions & 8 deletions frontend/src/lib/components/CommandBar/CommandBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,16 @@ const CommandBarOverlay = forwardRef<HTMLDivElement, CommandBarOverlayProps>(fun
backdropFilter: 'blur(var(--modal-backdrop-blur))',
}}
>
<div
data-attr="command-bar"
className={`w-full ${
barStatus === BarStatus.SHOW_SEARCH && 'h-160'
} max-w-lg bg-bg-3000 rounded overflow-hidden flex flex-col border shadow`}
ref={ref}
>
{children}
<div className="h-160 w-full max-w-lg">
<div
data-attr="command-bar"
className={`w-full ${
barStatus === BarStatus.SHOW_SEARCH && 'h-160'
} bg-bg-3000 rounded overflow-hidden border shadow`}
ref={ref}
>
{children}
</div>
</div>
</div>
)
Expand Down

0 comments on commit 79b28d0

Please sign in to comment.