Skip to content

Commit

Permalink
chore(3000): Unflag the Docs side panel (#18616)
Browse files Browse the repository at this point in the history
  • Loading branch information
Twixes authored Nov 15, 2023
1 parent 51609ed commit 76d085f
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,7 @@ export const sidePanelLogic = kea<sidePanelLogicType>([
tabs.push(SidePanelTab.Support)
}

if (featureFlags[FEATURE_FLAGS.SIDE_PANEL_DOCS]) {
tabs.push(SidePanelTab.Docs)
}

tabs.push(SidePanelTab.Docs)
tabs.push(SidePanelTab.Settings)
tabs.push(SidePanelTab.Activation)

Expand Down
1 change: 0 additions & 1 deletion frontend/src/lib/constants.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,6 @@ export const FEATURE_FLAGS = {
NOTEBOOK_CANVASES: 'notebook-canvases', // owner: #team-monitoring
SESSION_RECORDING_SAMPLING: 'session-recording-sampling', // owner: #team-monitoring
PERSON_FEED_CANVAS: 'person-feed-canvas', // owner: #project-canvas
SIDE_PANEL_DOCS: 'side-panel-docs', // owner: #noteforce-3000
MULTI_PROJECT_FEATURE_FLAGS: 'multi-project-feature-flags', // owner: @jurajmajerik #team-feature-success
NETWORK_PAYLOAD_CAPTURE: 'network-payload-capture', // owner: #team-monitoring
} as const
Expand Down
3 changes: 1 addition & 2 deletions frontend/src/lib/lemon-ui/Link/Link.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ export const Link: React.FC<LinkProps & React.RefAttributes<HTMLElement>> = Reac
href: typeof to === 'string' ? to : undefined,
})

const docsPanelEnabled = useFeatureFlag('SIDE_PANEL_DOCS')
const is3000 = useFeatureFlag('POSTHOG_3000')
const { openDocsPage } = useActions(sidePanelDocsLogic)

Expand All @@ -99,7 +98,7 @@ export const Link: React.FC<LinkProps & React.RefAttributes<HTMLElement>> = Reac
return
}

if (typeof to === 'string' && is3000 && docsPanelEnabled && isPostHogComDomain(to)) {
if (typeof to === 'string' && is3000 && isPostHogComDomain(to)) {
event.preventDefault()
openDocsPage(to)
return
Expand Down

0 comments on commit 76d085f

Please sign in to comment.