Skip to content

Commit

Permalink
add table
Browse files Browse the repository at this point in the history
  • Loading branch information
jurajmajerik committed Mar 26, 2024
1 parent fad9f5e commit 74a7b5b
Show file tree
Hide file tree
Showing 5 changed files with 285 additions and 99 deletions.
12 changes: 12 additions & 0 deletions frontend/src/scenes/experiments/Experiment.scss
Original file line number Diff line number Diff line change
Expand Up @@ -187,4 +187,16 @@
.InsightViz .LemonTable__cell--sticky::before {
background: var(--bg-table);
}

.secondary-metrics-table .LemonTable__content > table > {
thead > tr > th {
padding-top: 0;
padding-bottom: 0;
}

tbody > tr > td {
padding-top: 0;
padding-bottom: 0;
}
}
}
12 changes: 6 additions & 6 deletions frontend/src/scenes/experiments/ExperimentNext.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,6 @@ export function ExperimentView(): JSX.Element {
<ProgressBar />
<Goal />
<Results />
<SecondaryMetricsTable
experimentId={experiment.id}
onMetricsChange={(metrics) => updateExperimentSecondaryMetrics(metrics)}
initialMetrics={experiment.secondary_metrics}
defaultAggregationType={experiment.parameters?.aggregation_group_type_index}
/>
<ExperimentGoalModal experimentId={experimentId} />
<ExperimentExposureModal experimentId={experimentId} />
</>
Expand All @@ -55,6 +49,12 @@ export function ExperimentView(): JSX.Element {
{experiment.start_date && <NoResultsEmptyState />}
</>
)}
<SecondaryMetricsTable
experimentId={experiment.id}
onMetricsChange={(metrics) => updateExperimentSecondaryMetrics(metrics)}
initialMetrics={experiment.secondary_metrics}
defaultAggregationType={experiment.parameters?.aggregation_group_type_index}
/>
<DistributionTable />
<ReleaseConditionsTable />
</>
Expand Down
Loading

0 comments on commit 74a7b5b

Please sign in to comment.