feat: Frontend support for file_format

PostHog · Mar 22, 2024 · 6fa3360 · 6fa3360
1 parent 64837d1
commit 6fa3360
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 0 deletions.
diff --git a/frontend/src/scenes/batch_exports/BatchExportEditForm.tsx b/frontend/src/scenes/batch_exports/BatchExportEditForm.tsx
@@ -242,6 +242,15 @@ export function BatchExportsEditFields({
                                     ]}
                                 />
                             </LemonField>
+
+                            <LemonField name="file_format" label="Format" className="flex-1">
+                                <LemonSelect
+                                    options={[
+                                        { value: 'JSONLines', label: 'JSON lines' },
+                                        { value: 'Parquet', label: 'Apache Parquet' },
+                                    ]}
+                                />
+                            </LemonField>
                         </div>
 
                         <div className="flex gap-4">

diff --git a/frontend/src/scenes/batch_exports/BatchExports.stories.tsx b/frontend/src/scenes/batch_exports/BatchExports.stories.tsx
@@ -42,6 +42,7 @@ export default {
                             include_events: [],
                             encryption: null,
                             kms_key_id: null,
+                            file_format: 'JSONLines',
                         },
                     },
                     start_at: null,

diff --git a/frontend/src/scenes/batch_exports/batchExportEditLogic.ts b/frontend/src/scenes/batch_exports/batchExportEditLogic.ts
@@ -90,6 +90,7 @@ export const batchExportFormFields = (
                   aws_secret_access_key: isNew ? (!config.aws_secret_access_key ? 'This field is required' : '') : '',
                   compression: '',
                   encryption: '',
+                  file_format: isNew ? (!config.file_format ? 'This field is required' : '') : '',
                   kms_key_id: !config.kms_key_id && config.encryption == 'aws:kms' ? 'This field is required' : '',
                   exclude_events: '',
                   include_events: '',

diff --git a/frontend/src/types.ts b/frontend/src/types.ts
@@ -3597,6 +3597,7 @@ export type BatchExportDestinationS3 = {
         encryption: string | null
         kms_key_id: string | null
         endpoint_url: string | null
+        file_format: string
     }
 }