fix tests

PostHog · Apr 21, 2024 · 6d25e56 · 6d25e56
1 parent afd068c
commit 6d25e56
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/posthog/api/test/__snapshots__/test_organization_feature_flag.ambr b/posthog/api/test/__snapshots__/test_organization_feature_flag.ambr
@@ -1525,7 +1525,8 @@
          "posthog_survey"."start_date",
          "posthog_survey"."end_date",
          "posthog_survey"."updated_at",
-         "posthog_survey"."archived"
+         "posthog_survey"."archived",
+         "posthog_survey"."responses_limit"
   FROM "posthog_survey"
   WHERE "posthog_survey"."linked_flag_id" = 2
   '''

diff --git a/posthog/api/test/__snapshots__/test_survey.ambr b/posthog/api/test/__snapshots__/test_survey.ambr
@@ -180,6 +180,7 @@
          "posthog_survey"."end_date",
          "posthog_survey"."updated_at",
          "posthog_survey"."archived",
+         "posthog_survey"."responses_limit",
          "posthog_featureflag"."id",
          "posthog_featureflag"."key",
          "posthog_featureflag"."name",

diff --git a/posthog/api/test/test_survey.py b/posthog/api/test/test_survey.py
@@ -853,6 +853,7 @@ def test_can_list_surveys(self):
                     "archived": False,
                     "start_date": None,
                     "end_date": None,
+                    "responses_limit": None,
                 }
             ],
         }

diff --git a/posthog/tasks/stop_surveys_reached_target.py b/posthog/tasks/stop_surveys_reached_target.py
@@ -46,10 +46,9 @@ def stop_surveys_reached_target() -> None:
     all_surveys = Survey.objects.exclude(responses_limit__isnull=True).only(
         "id", "responses_limit", "team_id", "created_at"
     )
-    if not all_surveys:
-        return
 
-    for team_id, team_surveys in groupby(all_surveys, lambda survey: survey.team_id):
+    all_surveys_sorted = sorted(all_surveys, key=lambda survey: survey.team_id)
+    for team_id, team_surveys in groupby(all_surveys_sorted, lambda survey: survey.team_id):
         team_surveys_list = list(team_surveys)
         surveys_ids = [survey.id for survey in team_surveys_list]
         earliest_survey_start_date = min([survey.created_at for survey in team_surveys_list])

diff --git a/posthog/tasks/test/test_stop_surveys_reached_target.py b/posthog/tasks/test/test_stop_surveys_reached_target.py
@@ -42,23 +42,23 @@ def test_stop_surveys_with_enough_responses(self) -> None:
                 created_by=self.user,
                 linked_flag=self.flag,
                 responses_limit=1,
-                created_at=now() - relativedelta(hours=12),
+                created_at=now(),
             ),
             Survey.objects.create(
                 name="2",
                 team=self.team1,
                 created_by=self.user,
                 linked_flag=self.flag,
                 responses_limit=1,
-                created_at=now() - relativedelta(hours=12),
+                created_at=now(),
             ),
             Survey.objects.create(
                 name="3",
                 team=self.team2,
                 created_by=self.user,
                 linked_flag=self.flag,
                 responses_limit=1,
-                created_at=now() - relativedelta(hours=12),
+                created_at=now(),
             ),
         ]