Skip to content

Commit

Permalink
fix: Improve label in row for other breakdown (#20276)
Browse files Browse the repository at this point in the history
  • Loading branch information
webjunkie authored Feb 14, 2024
1 parent b98c15f commit 69823d2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/container-images-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ jobs:
message: |
{
"image_tag": "${{ steps.build.outputs.digest }}"
}
}
- name: Check for changes in plugins directory
id: check_changes_plugins
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/scenes/insights/utils.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -263,15 +263,15 @@ export function formatBreakdownLabel(
return cohorts?.filter((c) => c.id == breakdown_value)[0]?.name ?? (breakdown_value || '').toString()
} else if (typeof breakdown_value == 'number') {
return isOtherBreakdown(breakdown_value)
? 'Other'
? 'Other (Groups all remaining values)'
: isNullBreakdown(breakdown_value)
? 'None'
: formatPropertyValueForDisplay
? formatPropertyValueForDisplay(breakdown, breakdown_value)?.toString() ?? 'None'
: String(breakdown_value)
} else if (typeof breakdown_value == 'string') {
return isOtherBreakdown(breakdown_value) || breakdown_value === 'nan'
? 'Other'
? 'Other (Groups all remaining values)'
: isNullBreakdown(breakdown_value) || breakdown_value === ''
? 'None'
: breakdown_value
Expand Down

0 comments on commit 69823d2

Please sign in to comment.