feat: less of a wall of text (#19546)

* feat: less of a wall of text * Update UI snapshots for `chromium` (1) * Update frontend/src/scenes/settings/project/TestAccountFiltersConfig.tsx Co-authored-by: Joe Martin <[email protected]> --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Joe Martin <[email protected]>
PostHog · Jan 2, 2024 · 6695c98 · 6695c98
1 parent 0c56fbe
commit 6695c98
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 24 deletions.
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-destinations-page--dark.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-destinations-page--dark.png
diff --git a/frontend/__snapshots__/scenes-app-pipeline--pipeline-destinations-page--light.png b/frontend/__snapshots__/scenes-app-pipeline--pipeline-destinations-page--light.png
diff --git a/...tend/__snapshots__/scenes-app-pipeline--pipeline-transformations-page--dark.png b/...tend/__snapshots__/scenes-app-pipeline--pipeline-transformations-page--dark.png
diff --git a/...end/__snapshots__/scenes-app-pipeline--pipeline-transformations-page--light.png b/...end/__snapshots__/scenes-app-pipeline--pipeline-transformations-page--light.png
diff --git a/frontend/src/scenes/settings/project/TestAccountFiltersConfig.tsx b/frontend/src/scenes/settings/project/TestAccountFiltersConfig.tsx
@@ -30,11 +30,11 @@ function TestAccountFiltersConfig(): JSX.Element {
                 {!!testAccountFilterWarningLabels && testAccountFilterWarningLabels.length > 0 && (
                     <LemonBanner type="warning" className="m-2">
                         <p>
-                            Positive filters here mean only events or persons matching these filters will be included.
-                            Internal and test account filters are normally excluding filters like does not equal or does
-                            not contain.
+                            You've added an <strong>inclusive</strong> filter, which means only matching events will be
+                            included. Filters are normally <strong>exclusive</strong>, such as <i>does not contain</i>,
+                            to filter out unwanted results.
                         </p>
-                        <p>Positive filters are currently set for the following properties: </p>
+                        <p>Inclusive filters are currently set for the following properties: </p>
                         <ul className="list-disc">
                             {testAccountFilterWarningLabels.map((l, i) => (
                                 <li key={i} className="ml-4">
@@ -90,33 +90,20 @@ export function ProjectAccountFiltersSetting(): JSX.Element {
     return (
         <>
             <p>
-                Increase the quality of your analytics results by filtering out events from internal sources, such as
-                team members, test accounts, or development environments.{' '}
-                <strong>The filters you apply here are added as extra filters when the toggle is switched on.</strong>{' '}
-                So, if you apply a cohort, it means you will only match users in that cohort.
+                These filters apply only to queries when the toggle is enabled. Adding filters here does not prevent
+                events or recordings being ingested.{' '}
+                <Link to={'https://posthog.com/tutorials/filter-internal-users'}>Learn more in our docs</Link>.
             </p>
-            <LemonBanner type="info">
-                Events and recordings will still be ingested and saved, but they will be excluded from any queries where
-                the "Filter out internal and test users" toggle is set. You can learn how to{' '}
-                <Link to="https://posthog.com/tutorials/fewer-unwanted-events" target="_blank">
-                    capture fewer events
-                </Link>{' '}
-                or how to{' '}
-                <Link to="https://posthog.com/tutorials/limit-session-recordings" target="_blank">
-                    capture fewer recordings
-                </Link>{' '}
-                in our docs.
-            </LemonBanner>
             <div className={'mt-4'}>
                 <strong>Example filters</strong>
                 <ul className="list-disc pl-4 mb-2">
                     <li>
-                        "<strong>Email</strong> does not contain <strong>yourcompany.com</strong>" to exclude all events
-                        from your company's team members.
+                        Add "<strong>Email</strong> does not contain <strong>yourcompany.com</strong>" to exclude your
+                        team.
                     </li>
                     <li>
-                        "<strong>Host</strong> does not contain <strong>localhost</strong>" to exclude all events from
-                        local development environments.
+                        Add "<strong>Host</strong> does not contain <strong>localhost</strong>" to exclude local
+                        environments.
                     </li>
                 </ul>
             </div>