feat(web-analytics): Support null as string in channel type (#21136)

Support null as string in channel type
PostHog · Mar 25, 2024 · 652b75d · 652b75d
1 parent d226bd0
commit 652b75d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/posthog/hogql/database/schema/channel_type.py b/posthog/hogql/database/schema/channel_type.py
@@ -63,7 +63,10 @@ def create_channel_type_expr(
     gad_source: ast.Expr,
 ) -> ast.Expr:
     def wrap_with_null_if_empty(expr: ast.Expr) -> ast.Expr:
-        return ast.Call(name="nullIf", args=[expr, ast.Constant(value="")])
+        return ast.Call(
+            name="nullIf",
+            args=[ast.Call(name="nullIf", args=[expr, ast.Constant(value="")]), ast.Constant(value="null")],
+        )
 
     return parse_expr(
         """

diff --git a/posthog/hogql/database/schema/test/test_channel_type.py b/posthog/hogql/database/schema/test/test_channel_type.py
@@ -121,6 +121,21 @@ def test_direct_empty_string(self):
             ),
         )
 
+    def test_direct_null_string(self):
+        self.assertEqual(
+            "Direct",
+            self._get_initial_channel_type(
+                {
+                    "$initial_referring_domain": "$direct",
+                    "$initial_utm_source": "null",
+                    "$initial_utm_medium": "null",
+                    "$initial_utm_campaign": "null",
+                    "$initial_gclid": "null",
+                    "$initial_gad_source": "null",
+                }
+            ),
+        )
+
     def test_cross_network(self):
         self.assertEqual(
             "Cross Network",