fix(periodic-digest): don't show completed experiments in launched li…

…st (#27186)
PostHog · Dec 30, 2024 · 65067f2 · 65067f2
1 parent 9002bfe
commit 65067f2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/posthog/tasks/periodic_digest.py b/posthog/tasks/periodic_digest.py
@@ -75,8 +75,16 @@ def get_teams_with_new_playlists(end: datetime, begin: datetime) -> QuerySet:
 
 
 def get_teams_with_new_experiments_launched(end: datetime, begin: datetime) -> QuerySet:
-    return Experiment.objects.filter(start_date__gt=begin, start_date__lte=end).values(
-        "team_id", "name", "id", "start_date"
+    return (
+        Experiment.objects.filter(
+            start_date__gt=begin,
+            start_date__lte=end,
+        )
+        .exclude(
+            end_date__gt=begin,
+            end_date__lte=end,
+        )
+        .values("team_id", "name", "id", "start_date")
     )
 
 

diff --git a/posthog/tasks/test/test_periodic_digest.py b/posthog/tasks/test/test_periodic_digest.py
@@ -116,8 +116,8 @@ def test_periodic_digest_report(self, mock_capture: MagicMock) -> None:
             completed_experiment = Experiment.objects.create(
                 team=self.team,
                 name="Completed Experiment",
-                start_date=now() + timedelta(days=1),
-                end_date=now() + timedelta(days=6),
+                start_date=now() + timedelta(days=6),
+                end_date=now() + timedelta(days=7),
                 feature_flag=flag_for_completed_experiment,
             )