fix: createEventsToDropByToken should handle tokens with multiple s…

…eparators (#20392)
PostHog · Feb 17, 2024 · 644cc6f · 644cc6f
1 parent 6c32341
commit 644cc6f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/plugin-server/src/utils/db/hub.ts b/plugin-server/src/utils/db/hub.ts
@@ -60,7 +60,9 @@ export function createEventsToDropByToken(eventsToDropByTokenStr?: string): Map<
     const eventsToDropByToken: Map<string, string[]> = new Map()
     if (eventsToDropByTokenStr) {
         eventsToDropByTokenStr.split(',').forEach((pair) => {
-            const [token, distinctID] = pair.split(':')
+            const separatorIndex = pair.indexOf(':')
+            const token = pair.substring(0, separatorIndex)
+            const distinctID = pair.substring(separatorIndex + 1)
             eventsToDropByToken.set(token, [...(eventsToDropByToken.get(token) || []), distinctID])
         })
     }

diff --git a/plugin-server/tests/utils/db/hub.test.ts b/plugin-server/tests/utils/db/hub.test.ts
@@ -0,0 +1,10 @@
+import { createEventsToDropByToken } from '../../../src/utils/db/hub'
+
+describe('createEventsToDropByToken', () => {
+    it('should split tokens on comma', () => {
+        expect(createEventsToDropByToken('x:y,x:z')).toEqual(new Map([['x', ['y', 'z']]]))
+    })
+    it('handles events with duplicate separators', () => {
+        expect(createEventsToDropByToken('x:a,x:y:z,x:b')).toEqual(new Map([['x', ['a', 'y:z', 'b']]]))
+    })
+})