Skip to content

Commit

Permalink
test(actions): Unskip E2E test (#22959)
Browse files Browse the repository at this point in the history
  • Loading branch information
Twixes authored Jun 13, 2024
1 parent bd6f570 commit 6290dae
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
6 changes: 2 additions & 4 deletions cypress/e2e/actions.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,14 @@ describe('Action Events', () => {
cy.get('[data-attr=trend-element-subject-1] span').should('contain', actionName)
})

// FIXME: This test fails after the 3000 rework, as the input field for new actions
// doesn't get cleared
it.skip('Notifies when an action event with this name already exists', () => {
it('Notifies when an action event with this name already exists', () => {
createAction(actionName)
navigateToActionsTab()
createAction(actionName)
// Oh noes, there already is an action with name `actionName`
cy.contains('Action with this name already exists').should('exist')
// Let's see it
cy.contains('Click here to edit').click()
cy.contains('Edit it here').click()
// We should now be seeing the action from "Create action"
cy.get('[data-attr=edit-action-url-input]').should('have.value', Cypress.config().baseUrl)
})
Expand Down
5 changes: 4 additions & 1 deletion frontend/src/scenes/actions/actionEditLogic.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,10 @@ export const actionEditLogic = kea<actionEditLogicType>([

lemonToast.error(
<>
Action with this name already exists. <Link to={urls.action(dupeId)}>Edit it</Link>
Action with this name already exists.{' '}
<Link to={urls.action(dupeId)} target="_blank">
Edit it here
</Link>
</>
)

Expand Down

0 comments on commit 6290dae

Please sign in to comment.