feat(notebooks): add error boundary around components (#24095)

PostHog · Jul 31, 2024 · 5e9739c · 5e9739c
1 parent 9a0e10f
commit 5e9739c
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/frontend/src/scenes/notebooks/Nodes/NodeWrapper.tsx b/frontend/src/scenes/notebooks/Nodes/NodeWrapper.tsx
@@ -259,11 +259,13 @@ function NodeWrapper<T extends CustomNotebookNodeAttributes>(props: NodeWrapperP
 
                                         {Settings && editingNodeId === nodeId && containerSize === 'small' ? (
                                             <div className="NotebookNode__settings">
-                                                <Settings
-                                                    key={nodeId}
-                                                    attributes={attributes}
-                                                    updateAttributes={updateAttributes}
-                                                />
+                                                <ErrorBoundary>
+                                                    <Settings
+                                                        key={nodeId}
+                                                        attributes={attributes}
+                                                        updateAttributes={updateAttributes}
+                                                    />
+                                                </ErrorBoundary>
                                             </div>
                                         ) : null}
 
@@ -278,7 +280,12 @@ function NodeWrapper<T extends CustomNotebookNodeAttributes>(props: NodeWrapperP
                                             onClick={!expanded && expandOnClick ? () => setExpanded(true) : undefined}
                                             onMouseDown={onResizeStart}
                                         >
-                                            <Component attributes={attributes} updateAttributes={updateAttributes} />
+                                            <ErrorBoundary>
+                                                <Component
+                                                    attributes={attributes}
+                                                    updateAttributes={updateAttributes}
+                                                />
+                                            </ErrorBoundary>
                                         </div>
                                     </>
                                 )}