Skip to content

Commit

Permalink
chore: update experiment types (#17754)
Browse files Browse the repository at this point in the history
  • Loading branch information
daibhin authored Oct 4, 2023
1 parent c959736 commit 5d16729
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 7 deletions.
5 changes: 4 additions & 1 deletion frontend/src/scenes/experiments/ExperimentPreview.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,10 @@ export function ExperimentPreview({
value={minimumDetectableChange}
onChange={(value) => {
setExperiment({
parameters: { ...experiment.parameters, minimum_detectable_effect: value },
parameters: {
...experiment.parameters,
minimum_detectable_effect: value ?? undefined,
},
})
}}
/>
Expand Down
14 changes: 8 additions & 6 deletions frontend/src/scenes/experiments/Experiments.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -226,12 +226,14 @@ export function Experiments(): JSX.Element {
setSearchStatus(status as ProgressStatus | 'all')
}
}}
options={[
{ label: 'All', value: 'all' },
{ label: 'Draft', value: ProgressStatus.Draft },
{ label: 'Running', value: ProgressStatus.Running },
{ label: 'Complete', value: ProgressStatus.Complete },
]}
options={
[
{ label: 'All', value: 'all' },
{ label: 'Draft', value: ProgressStatus.Draft },
{ label: 'Running', value: ProgressStatus.Running },
{ label: 'Complete', value: ProgressStatus.Complete },
] as { label: string; value: string }[]
}
value="all"
dropdownMaxContentWidth
/>
Expand Down

0 comments on commit 5d16729

Please sign in to comment.