Skip to content

Commit

Permalink
feat: console search is no longer beta (#19548)
Browse files Browse the repository at this point in the history
* feat: console search is no longer beta

* Update UI snapshots for `chromium` (1)

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
  • Loading branch information
pauldambra and github-actions[bot] authored Jan 2, 2024
1 parent b844f21 commit 5c97d04
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 33 deletions.
8 changes: 0 additions & 8 deletions frontend/src/lib/components/CommandBar/CommandBar.stories.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -327,14 +327,6 @@ const SEARCH_RESULT = {
description: '',
},
},
{
type: 'feature_flag',
result_id: '161',
extra_fields: {
key: 'console-recording-search',
name: 'console-recording-search',
},
},
{
type: 'feature_flag',
result_id: '134',
Expand Down
1 change: 0 additions & 1 deletion frontend/src/lib/constants.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,6 @@ export const FEATURE_FLAGS = {
WEBHOOKS_DENYLIST: 'webhooks-denylist', // owner: #team-pipeline
SURVEYS_RESULTS_VISUALIZATIONS: 'surveys-results-visualizations', // owner: @jurajmajerik
SURVEYS_PAYGATES: 'surveys-paygates',
CONSOLE_RECORDING_SEARCH: 'console-recording-search', // owner: #team-replay
PERSONS_HOGQL_QUERY: 'persons-hogql-query', // owner: @mariusandra
PIPELINE_UI: 'pipeline-ui', // owner: #team-pipeline
NOTEBOOK_CANVASES: 'notebook-canvases', // owner: #team-replay
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
import { LemonButtonWithDropdown, LemonCheckbox, LemonInput, LemonTag, Tooltip } from '@posthog/lemon-ui'
import { LemonButtonWithDropdown, LemonCheckbox, LemonInput } from '@posthog/lemon-ui'
import { useValues } from 'kea'
import { DateFilter } from 'lib/components/DateFilter/DateFilter'
import { FlaggedFeature } from 'lib/components/FlaggedFeature'
import { PropertyFilters } from 'lib/components/PropertyFilters/PropertyFilters'
import { TaxonomicFilterGroupType } from 'lib/components/TaxonomicFilter/types'
import { FEATURE_FLAGS } from 'lib/constants'
import { LemonLabel } from 'lib/lemon-ui/LemonLabel/LemonLabel'
import { ActionFilter } from 'scenes/insights/filters/ActionFilter/ActionFilter'
import { MathAvailability } from 'scenes/insights/filters/ActionFilter/ActionFilterRow/ActionFilterRow'
Expand Down Expand Up @@ -149,27 +147,18 @@ function ConsoleFilters({
return (
<>
<LemonLabel>Filter by console logs</LemonLabel>
<FlaggedFeature flag={FEATURE_FLAGS.CONSOLE_RECORDING_SEARCH}>
<div className={'flex flex-row space-x-2'}>
<LemonInput
className={'grow'}
placeholder={'containing text'}
value={filters.console_search_query}
onChange={(s: string): void => {
setFilters({
console_search_query: s,
})
}}
/>

<Tooltip
placement="bottom"
title={<>Filter recordings by console logs. Only matches recordings since October 4th.</>}
>
<LemonTag type={'highlight'}>Beta</LemonTag>
</Tooltip>
</div>
</FlaggedFeature>
<div className={'flex flex-row space-x-2'}>
<LemonInput
className={'grow'}
placeholder={'containing text'}
value={filters.console_search_query}
onChange={(s: string): void => {
setFilters({
console_search_query: s,
})
}}
/>
</div>
<LemonButtonWithDropdown
status="stealth"
type="secondary"
Expand Down

0 comments on commit 5c97d04

Please sign in to comment.