fix: Unify what's new to go to the changelog (#19985)

* fix: Opening of a docs link via state * Fix * Removed old assets * Fix mobile experience --------- Co-authored-by: Michael Matloka <[email protected]>
PostHog · Jan 30, 2024 · 5ad5811 · 5ad5811
1 parent 5fdf645
commit 5ad5811
Show file tree

Hide file tree

Showing 22 changed files with 23 additions and 339 deletions.
diff --git a/frontend/public/3000/3000-command-palette-dark.png b/frontend/public/3000/3000-command-palette-dark.png
diff --git a/frontend/public/3000/3000-command-palette.png b/frontend/public/3000/3000-command-palette.png
diff --git a/frontend/public/3000/3000-dark-mode.png b/frontend/public/3000/3000-dark-mode.png
diff --git a/frontend/public/3000/3000-launch.png b/frontend/public/3000/3000-launch.png
diff --git a/frontend/public/3000/3000-nav-dark.png b/frontend/public/3000/3000-nav-dark.png
diff --git a/frontend/public/3000/3000-nav.png b/frontend/public/3000/3000-nav.png
diff --git a/frontend/public/3000/3000-notebooks-dark.png b/frontend/public/3000/3000-notebooks-dark.png
diff --git a/frontend/public/3000/3000-notebooks.png b/frontend/public/3000/3000-notebooks.png
diff --git a/frontend/public/3000/3000-search-dark.png b/frontend/public/3000/3000-search-dark.png
diff --git a/frontend/public/3000/3000-search.png b/frontend/public/3000/3000-search.png
diff --git a/frontend/public/3000/3000-side-panel-dark.png b/frontend/public/3000/3000-side-panel-dark.png
diff --git a/frontend/public/3000/3000-side-panel.png b/frontend/public/3000/3000-side-panel.png
diff --git a/frontend/public/3000/3000-toolbar.png b/frontend/public/3000/3000-toolbar.png
diff --git a/frontend/src/layout/navigation-3000/navigationLogic.tsx b/frontend/src/layout/navigation-3000/navigationLogic.tsx
@@ -59,6 +59,7 @@ export const navigation3000Logic = kea<navigation3000LogicType>([
     props({} as { inputElement?: HTMLInputElement | null }),
     connect(() => ({
         values: [sceneLogic, ['sceneConfig'], navigationLogic, ['mobileLayout'], teamLogic, ['currentTeam']],
+        actions: [navigationLogic, ['closeAccountPopover']],
     })),
     actions({
         hideSidebar: true,
@@ -133,6 +134,7 @@ export const navigation3000Logic = kea<navigation3000LogicType>([
             {
                 showNavOnMobile: () => true,
                 hideNavOnMobile: () => false,
+                closeAccountPopover: () => false,
             },
         ],
         isSidebarKeyboardShortcutAcknowledged: [

diff --git a/frontend/src/layout/navigation-3000/sidepanel/SidePanel.stories.tsx b/frontend/src/layout/navigation-3000/sidepanel/SidePanel.stories.tsx
@@ -45,10 +45,6 @@ export const SidePanelDocs: StoryFn = () => {
     return <BaseTemplate panel={SidePanelTab.Docs} />
 }
 
-export const SidePanelWelcome: StoryFn = () => {
-    return <BaseTemplate panel={SidePanelTab.Welcome} />
-}
-
 export const SidePanelSettings: StoryFn = () => {
     return <BaseTemplate panel={SidePanelTab.Settings} />
 }

diff --git a/frontend/src/layout/navigation-3000/sidepanel/SidePanel.tsx b/frontend/src/layout/navigation-3000/sidepanel/SidePanel.tsx
@@ -1,6 +1,6 @@
 import './SidePanel.scss'
 
-import { IconConfetti, IconEllipsis, IconFeatures, IconGear, IconInfo, IconNotebook, IconSupport } from '@posthog/icons'
+import { IconEllipsis, IconFeatures, IconGear, IconInfo, IconNotebook, IconSupport } from '@posthog/icons'
 import { LemonButton, LemonMenu, LemonMenuItems } from '@posthog/lemon-ui'
 import clsx from 'clsx'
 import { useActions, useValues } from 'kea'
@@ -19,7 +19,6 @@ import { SidePanelFeaturePreviews } from './panels/SidePanelFeaturePreviews'
 import { SidePanelSettings } from './panels/SidePanelSettings'
 import { SidePanelStatus, SidePanelStatusIcon } from './panels/SidePanelStatus'
 import { SidePanelSupport } from './panels/SidePanelSupport'
-import { SidePanelWelcome } from './panels/SidePanelWelcome'
 import { sidePanelLogic } from './sidePanelLogic'
 import { sidePanelStateLogic } from './sidePanelStateLogic'
 
@@ -67,11 +66,6 @@ export const SIDE_PANEL_TABS: Record<SidePanelTab, { label: string; Icon: any; C
         Icon: SidePanelDiscussionIcon,
         Content: SidePanelDiscussion,
     },
-    [SidePanelTab.Welcome]: {
-        label: "What's new?",
-        Icon: IconConfetti,
-        Content: SidePanelWelcome,
-    },
     [SidePanelTab.Status]: {
         label: 'System status',
         Icon: SidePanelStatusIcon,

diff --git a/frontend/src/layout/navigation-3000/sidepanel/panels/SidePanelWelcome.scss b/frontend/src/layout/navigation-3000/sidepanel/panels/SidePanelWelcome.scss
diff --git a/frontend/src/layout/navigation-3000/sidepanel/panels/SidePanelWelcome.tsx b/frontend/src/layout/navigation-3000/sidepanel/panels/SidePanelWelcome.tsx
diff --git a/frontend/src/layout/navigation-3000/sidepanel/panels/sidePanelDocsLogic.ts b/frontend/src/layout/navigation-3000/sidepanel/panels/sidePanelDocsLogic.ts
@@ -25,7 +25,7 @@ export const sidePanelDocsLogic = kea<sidePanelDocsLogicType>([
     path(['scenes', 'navigation', 'sidepanel', 'sidePanelDocsLogic']),
     connect({
         actions: [sidePanelStateLogic, ['openSidePanel', 'closeSidePanel']],
-        values: [sceneLogic, ['sceneConfig']],
+        values: [sceneLogic, ['sceneConfig'], sidePanelStateLogic, ['selectedTabOptions']],
     }),
 
     actions({
@@ -85,7 +85,13 @@ export const sidePanelDocsLogic = kea<sidePanelDocsLogicType>([
     })),
 
     afterMount(({ actions, values }) => {
-        if (values.sceneConfig?.defaultDocsPath) {
+        // If a destination was set in the options, use that
+        // otherwise the default for the current scene
+        // otherwise, whatever it last was set to
+        if (values.selectedTabOptions) {
+            const initialPath = getPathFromUrl(values.selectedTabOptions)
+            actions.setInitialPath(initialPath)
+        } else if (values.sceneConfig?.defaultDocsPath) {
             actions.setInitialPath(values.sceneConfig?.defaultDocsPath)
         }
     }),