Fix code review suggestions

PostHog · Mar 22, 2024 · 5795cb2 · 5795cb2
1 parent 7c6cf17
commit 5795cb2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 13 deletions.
diff --git a/frontend/src/queries/nodes/InsightQuery/utils/filtersToQueryNode.ts b/frontend/src/queries/nodes/InsightQuery/utils/filtersToQueryNode.ts
@@ -475,16 +475,14 @@ export const pathsFilterToQuery = (filters: Partial<PathsFilterType>): PathsFilt
         pathGroupings: filters.path_groupings,
         funnelPaths: filters.funnel_paths,
         funnelFilter: filters.funnel_filter,
-        funnelActorsQuery: filters.funnel_filter
-            ? ({
-                  kind: NodeKind.FunnelsActorsQuery,
-                  source: {
-                      funnelsFilter: funnelsFilterToQuery(filters.funnel_filter),
-                      ...filtersToQueryNode(filters.funnel_filter),
-                  },
-                  funnelStep: filters.funnel_filter.funnel_step,
-              } as FunnelsActorsQuery)
-            : undefined,
+        funnelActorsQuery:
+            filters.funnel_filter && Object.keys(filters.funnel_filter).length > 0
+                ? ({
+                      kind: NodeKind.FunnelsActorsQuery,
+                      source: filtersToQueryNode(filters.funnel_filter),
+                      funnelStep: filters.funnel_filter.funnel_step,
+                  } as FunnelsActorsQuery)
+                : undefined,
         excludeEvents: filters.exclude_events,
         stepLimit: filters.step_limit,
         pathReplacements: filters.path_replacements,

diff --git a/posthog/hogql_queries/insights/paths_query_runner.py b/posthog/hogql_queries/insights/paths_query_runner.py
@@ -520,9 +520,6 @@ def get_session_threshold_clause(self) -> ast.Expr:
                 interval = self.query.pathsFilter.funnelActorsQuery.source.funnelsFilter.funnelWindowInterval
                 unit = self.query.pathsFilter.funnelActorsQuery.source.funnelsFilter.funnelWindowIntervalUnit
                 interval_unit = funnel_window_interval_unit_to_sql(unit)
-            # TODO: Figure out if funnelWindowDays still used
-            # elif self.query.pathsFilter.funnelActorsQuery.source.funnelsFilter.funnelWindowDays:
-            #    interval = self.query.pathsFilter.funnelActorsQuery.source.funnelsFilter.funnelWindowDays
 
             return parse_expr(
                 f"arraySplit(x -> if(toDateTime('2018-01-01') + toIntervalSecond(_toInt64(x.3)) < toDateTime('2018-01-01') + INTERVAL {interval} {interval_unit}, 0, 1), paths_tuple)"