fix(data-warehouse): Pop the incremental value when changing to/from …

…incremental (#27086)
PostHog · Dec 20, 2024 · 571e20b · 571e20b
1 parent 5d7fb8b
commit 571e20b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/posthog/temporal/data_imports/workflow_activities/import_data_sync.py b/posthog/temporal/data_imports/workflow_activities/import_data_sync.py
@@ -101,6 +101,9 @@ def import_data_activity_sync(inputs: ImportDataActivityInputs):
                 schema.sync_type_config.get("incremental_field_type"),
             )
 
+        if schema.is_incremental:
+            logger.debug(f"Incremental last value being used is: {processed_incremental_last_value}")
+
         source = None
         if model.pipeline.source_type == ExternalDataSource.Type.STRIPE:
             from posthog.temporal.data_imports.pipelines.stripe import stripe_source

diff --git a/posthog/warehouse/api/external_data_schema.py b/posthog/warehouse/api/external_data_schema.py
@@ -141,12 +141,16 @@ def update(self, instance: ExternalDataSchema, validated_data: dict[str, Any]) -
             payload = instance.sync_type_config
             payload["incremental_field"] = data.get("incremental_field")
             payload["incremental_field_type"] = data.get("incremental_field_type")
+            payload["incremental_field_last_value"] = None
+            payload["incremental_field_last_value_v2"] = None
 
             validated_data["sync_type_config"] = payload
         else:
             payload = instance.sync_type_config
             payload.pop("incremental_field", None)
             payload.pop("incremental_field_type", None)
+            payload.pop("incremental_field_last_value", None)
+            payload.pop("incremental_field_last_value_v2", None)
 
             validated_data["sync_type_config"] = payload