Skip to content

Commit

Permalink
feat(err): r/error-tracking/cymbal/g (#25358)
Browse files Browse the repository at this point in the history
  • Loading branch information
oliverb123 authored Oct 3, 2024
1 parent 6464938 commit 54dc40b
Show file tree
Hide file tree
Showing 10 changed files with 35 additions and 28 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/rust-docker-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
dockerfile: ./rust/Dockerfile
- image: property-defs-rs
dockerfile: ./rust/Dockerfile
- image: error-tracking
- image: cymbal
dockerfile: ./rust/Dockerfile
runs-on: depot-ubuntu-22.04-4
permissions:
Expand All @@ -48,7 +48,7 @@ jobs:
hook-janitor_digest: ${{ steps.digest.outputs.hook-janitor_digest }}
hook-worker_digest: ${{ steps.digest.outputs.hook-worker_digest }}
hook-migrator_digest: ${{ steps.digest.outputs.hook-migrator_digest }}
error-tracking-rs_digest: ${{ steps.digest.outputs.error-tracking-rs_digest }}
cymbal_digest: ${{ steps.digest.outputs.cymbal_digest }}

defaults:
run:
Expand Down Expand Up @@ -144,10 +144,10 @@ jobs:
values:
image:
sha: '${{ needs.build.outputs.property-defs-rs_digest }}'
# - release: error-tracking-rs - disabled until a charts in place, for now we just build
# - release: cymbal - disabled until a charts in place, for now we just build
# values:
# image:
# sha: '${{ needs.build.outputs.error-tracking-rs_digest }}'
# sha: '${{ needs.build.outputs.cymbal_digest }}'
- release: hoghooks
values:
api_image:
Expand Down
40 changes: 20 additions & 20 deletions rust/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rust/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ members = [
"cyclotron-node",
"cyclotron-janitor",
"cyclotron-fetch",
"error-tracking",
"cymbal",
]

[workspace.lints.rust]
Expand Down
2 changes: 1 addition & 1 deletion rust/error-tracking/Cargo.toml → rust/cymbal/Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[package]
name = "error-tracking"
name = "cymbal"
version = "0.1.0"
edition = "2021"

Expand Down
2 changes: 1 addition & 1 deletion rust/error-tracking/README.md → rust/cymbal/README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Error tracking
# Cymbal, for error tracking

You throw 'em, we catch 'em.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ pub struct Config {
// Rust service connect directly to postgres, not via pgbouncer, so we keep this low
#[envconfig(default = "4")]
pub max_pg_connections: u32,

// These are unused for now, but useful while iterating in prod
#[envconfig(default = "true")]
pub skip_writes: bool,

#[envconfig(default = "true")]
pub skip_reads: bool,
}

impl Config {
Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ use std::{future::ready, sync::Arc};
use axum::{routing::get, Router};
use common_kafka::kafka_consumer::RecvErr;
use common_metrics::{serve, setup_metrics_routes};
use cymbal::{app_context::AppContext, config::Config, error::Error};
use envconfig::Envconfig;
use error_tracking::{app_context::AppContext, config::Config, error::Error};
use serde_json::Value;
use tokio::task::JoinHandle;
use tracing::{error, info};
Expand Down

0 comments on commit 54dc40b

Please sign in to comment.